Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rules): Make segment be one of two types #1978

Merged
merged 2 commits into from
Aug 10, 2023
Merged

Conversation

yquansah
Copy link
Contributor

@yquansah yquansah commented Aug 10, 2023

Make segment under rules respect one of two types.

This:

rules:
  segment: "foo"

Or:

rules:
  segment:
    keys:
    - foo
    - bar
    operator: AND_SEGMENT_OPERATOR

@yquansah yquansah requested a review from a team as a code owner August 10, 2023 04:02
@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #1978 (f168d32) into segment-anding (45149d6) will increase coverage by 0.22%.
Report is 5 commits behind head on segment-anding.
The diff coverage is 76.66%.

@@                Coverage Diff                 @@
##           segment-anding    #1978      +/-   ##
==================================================
+ Coverage           70.94%   71.16%   +0.22%     
==================================================
  Files                  67       68       +1     
  Lines                6718     6742      +24     
==================================================
+ Hits                 4766     4798      +32     
+ Misses               1677     1672       -5     
+ Partials              275      272       -3     
Files Changed Coverage Δ
internal/storage/fs/snapshot.go 68.08% <27.27%> (-1.07%) ⬇️
internal/ext/common.go 84.61% <84.61%> (ø)
internal/ext/exporter.go 85.47% <85.71%> (+2.91%) ⬆️
internal/ext/importer.go 71.11% <100.00%> (+4.22%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! very nice

@yquansah yquansah merged commit 524f277 into segment-anding Aug 10, 2023
22 checks passed
@yquansah yquansah deleted the segment-field branch August 10, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants