-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add redis connection optional params #1983
feat: add redis connection optional params #1983
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple minor suggestions on config value names for consistency, but otherwise ❤️ it! thank you @rudineirk for the PR
Codecov Report
@@ Coverage Diff @@
## main #1983 +/- ##
==========================================
- Coverage 70.96% 70.86% -0.11%
==========================================
Files 68 68
Lines 6579 6596 +17
==========================================
+ Hits 4669 4674 +5
- Misses 1646 1658 +12
Partials 264 264
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
also thank you for updating the cue and JSON schema files as well!! |
f3fe94b
to
6a42b01
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great! ty again. will come out in the next release, likely early next week
Add the following redis configs: