Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add redis connection optional params #1983

Merged

Conversation

rudineirk
Copy link
Contributor

@rudineirk rudineirk commented Aug 11, 2023

Add the following redis configs:

cache:
  enabled: true
  backend: redis
  ttl: 60s
  redis:
    host: localhost
    port: 6378
    require_tls: true # new
    db: 1
    password: "s3cr3t!"
    pool_size: 50 # new
    min_idle_conn: 2 # new
    conn_max_idle_time: 10m # new
    net_timeout: 500ms # new

@rudineirk rudineirk requested a review from a team as a code owner August 11, 2023 14:48
Copy link
Collaborator

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple minor suggestions on config value names for consistency, but otherwise ❤️ it! thank you @rudineirk for the PR

config/flipt.schema.cue Outdated Show resolved Hide resolved
config/flipt.schema.cue Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #1983 (6a42b01) into main (d38a357) will decrease coverage by 0.11%.
The diff coverage is 37.50%.

@@            Coverage Diff             @@
##             main    #1983      +/-   ##
==========================================
- Coverage   70.96%   70.86%   -0.11%     
==========================================
  Files          68       68              
  Lines        6579     6596      +17     
==========================================
+ Hits         4669     4674       +5     
- Misses       1646     1658      +12     
  Partials      264      264              
Files Changed Coverage Δ
internal/cmd/grpc.go 0.00% <0.00%> (ø)
internal/config/cache.go 100.00% <ø> (ø)
internal/config/config.go 88.27% <100.00%> (+0.18%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@markphelps
Copy link
Collaborator

also thank you for updating the cue and JSON schema files as well!!

@rudineirk rudineirk force-pushed the feat/add-redis-connection-optional-params branch from f3fe94b to 6a42b01 Compare August 11, 2023 16:22
Copy link
Collaborator

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! ty again. will come out in the next release, likely early next week

@markphelps markphelps enabled auto-merge (squash) August 11, 2023 16:53
@markphelps markphelps merged commit 492cc0b into flipt-io:main Aug 11, 2023
19 of 22 checks passed
@markphelps markphelps added the needs docs Requires documentation updates label Aug 11, 2023
@markphelps markphelps removed the needs docs Requires documentation updates label Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants