Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): make flags/segments inputs disabled in readonly mode #1986

Merged
merged 2 commits into from
Aug 12, 2023

Conversation

markphelps
Copy link
Collaborator

Fixes: FLI-556

Makes flag/segment name/desc/flag type inputs disabled when in readonly mode

Before

CleanShot 2023-08-12 at 14 07 01

After

CleanShot 2023-08-12 at 14 06 00

@markphelps markphelps requested a review from a team as a code owner August 12, 2023 18:08
@codecov
Copy link

codecov bot commented Aug 12, 2023

Codecov Report

Merging #1986 (70871ea) into main (492cc0b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1986   +/-   ##
=======================================
  Coverage   70.86%   70.86%           
=======================================
  Files          68       68           
  Lines        6596     6596           
=======================================
  Hits         4674     4674           
  Misses       1658     1658           
  Partials      264      264           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@markphelps markphelps merged commit 82b7158 into main Aug 12, 2023
25 checks passed
@markphelps markphelps deleted the flag-segment-readonly-inputs branch August 12, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants