Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): copy flag/segment key to clipboard button in ui #1987

Merged
merged 4 commits into from
Aug 14, 2023

Conversation

markphelps
Copy link
Collaborator

Fixes: FLI-555

Small improvement requested by a user to add copy to clipboard buttons for flagKey, went ahead and did the same for segmentKey as well

2023-08-12 14 34 27

@markphelps markphelps requested a review from a team as a code owner August 12, 2023 18:48
@codecov
Copy link

codecov bot commented Aug 12, 2023

Codecov Report

Merging #1987 (8f78461) into main (9291926) will decrease coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1987      +/-   ##
==========================================
- Coverage   70.86%   70.77%   -0.10%     
==========================================
  Files          68       68              
  Lines        6596     6596              
==========================================
- Hits         4674     4668       -6     
- Misses       1658     1662       +4     
- Partials      264      266       +2     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Base automatically changed from flag-segment-readonly-inputs to main August 12, 2023 19:25
Copy link
Contributor

@GeorgeMac GeorgeMac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💅

@markphelps markphelps enabled auto-merge (squash) August 14, 2023 11:19
@markphelps markphelps merged commit 33d559a into main Aug 14, 2023
24 of 25 checks passed
@markphelps markphelps deleted the copy-keys-to-clipboard branch August 14, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants