Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: default to ~/Library/Application\ Support/flipt for db sqlite file on mac #2039

Merged
merged 17 commits into from
Aug 23, 2023

Conversation

markphelps
Copy link
Collaborator

Fixes: FLI-554

  • On macOS we default the Sqlite DB to ~/Library/Application\ Support/flipt/flipt.db
  • On linux we continue to default to /var/opt/flipt/flipt.db
  • Removes unused db.migrations configs

@markphelps markphelps requested a review from a team as a code owner August 22, 2023 17:43
@markphelps markphelps added the needs docs Requires documentation updates label Aug 22, 2023
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #2039 (1199397) into main (a92355c) will decrease coverage by 0.02%.
The diff coverage is 82.97%.

@@            Coverage Diff             @@
##             main    #2039      +/-   ##
==========================================
- Coverage   70.60%   70.58%   -0.02%     
==========================================
  Files          71       72       +1     
  Lines        6791     6814      +23     
==========================================
+ Hits         4795     4810      +15     
- Misses       1728     1733       +5     
- Partials      268      271       +3     
Files Changed Coverage Δ
internal/config/deprecations.go 100.00% <ø> (ø)
internal/config/config.go 86.96% <44.44%> (-1.31%) ⬇️
internal/config/database.go 91.66% <66.66%> (-8.34%) ⬇️
internal/config/audit.go 92.85% <100.00%> (+0.54%) ⬆️
internal/config/authentication.go 72.22% <100.00%> (+0.31%) ⬆️
internal/config/cache.go 100.00% <100.00%> (ø)
internal/config/cors.go 100.00% <100.00%> (ø)
internal/config/database_linux.go 100.00% <100.00%> (ø)
internal/config/log.go 100.00% <100.00%> (ø)
internal/config/meta.go 100.00% <100.00%> (ø)
... and 4 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@yquansah yquansah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from macos-quill to main August 22, 2023 18:59
Copy link
Contributor

@GeorgeMac GeorgeMac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

@markphelps markphelps merged commit 06a899b into main Aug 23, 2023
24 of 25 checks passed
@markphelps markphelps deleted the macos-default-db branch August 23, 2023 11:03
@markphelps markphelps removed the needs docs Requires documentation updates label Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants