feat: default config #2067
feat: default config #2067
Conversation
|
|
||
| package main | ||
|
|
||
| var defaultCfgPath string |
There was a problem hiding this comment.
i guess another alternative is to check the OS at runtime instead of using build tags and an empty var here, anyone have a pref over one or the other?
There was a problem hiding this comment.
I think this is cool. It follows the pattern of the other things we are doing with build tags as well, so just for consistency.
There was a problem hiding this comment.
wdyt @GeorgeMac ?
There was a problem hiding this comment.
Yeah im for that. I was going to say, as long as we warn as such. But you've done that, so all gravy to me 👍
There was a problem hiding this comment.
yeah was debating on if this should be at Info level instead of Warning
Codecov Report
@@ Coverage Diff @@
## main #2067 +/- ##
=======================================
Coverage 70.41% 70.41%
=======================================
Files 70 70
Lines 6822 6822
=======================================
Hits 4804 4804
Misses 1741 1741
Partials 277 277
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
|
||
| package main | ||
|
|
||
| var defaultCfgPath string |
There was a problem hiding this comment.
Yeah im for that. I was going to say, as long as we warn as such. But you've done that, so all gravy to me 👍
Fixes: FLI-580
Change: Uses the default config values if no config file found
This is a departure from our previous approach of erroring if there is no config file