Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: specify region to fix s3 feature #2193

Merged
merged 2 commits into from
Oct 3, 2023
Merged

chore: specify region to fix s3 feature #2193

merged 2 commits into from
Oct 3, 2023

Conversation

yquansah
Copy link
Contributor

@yquansah yquansah commented Oct 3, 2023

The application was not honoring the region configuration.

This PR will set the region value from configuration wherever it was set, either environment variable or configuration file.

Without this the following error occurred:

Error: Open .flipt.yml: operation error S3: GetObject, https response error StatusCode: 400, RequestID: N7MN8TJY9CFY5BXF, HostID: 7KtR0/CRqaCS7aU4+8LLyDz9MTw2aFPEE/a7VSMUk6JE5DEnl8xCYalJHuBBkCKiB9rN65cZmb8=, api error AuthorizationHeaderMalformed: The authorization header is malformed; a non-empty region must be provided in the credential.

@yquansah yquansah requested a review from a team as a code owner October 3, 2023 02:03
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #2193 (eb414ec) into main (fba0ec1) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2193   +/-   ##
=======================================
  Coverage   70.55%   70.55%           
=======================================
  Files          76       76           
  Lines        7240     7240           
=======================================
  Hits         5108     5108           
  Misses       1833     1833           
  Partials      299      299           
Files Coverage Δ
internal/storage/fs/s3/source.go 79.41% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yquansah yquansah merged commit 0a29bbf into main Oct 3, 2023
25 checks passed
@yquansah yquansah deleted the fix-region branch October 3, 2023 13:41
@markphelps markphelps mentioned this pull request Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants