feat(cmd/bundle): add new bundle build sub-commands #2334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Uffizzi Preview |
markphelps
requested changes
Nov 3, 2023
GeorgeMac
force-pushed
the
gm/fs-oci-source
branch
from
322cc22
to
8b8210e
Compare
Codecov Report
@@ Coverage Diff @@
## gm/fs-oci #2334 +/- ##
=============================================
- Coverage 70.85% 70.66% -0.19%
=============================================
Files 80 81 +1
Lines 7679 7892 +213
=============================================
+ Hits 5441 5577 +136
- Misses 1918 1977 +59
- Partials 320 338 +18
... and 1 file with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
GeorgeMac
force-pushed
the
gm/bundles-build
branch
from
3e91100
to
b6248a2
Compare
markphelps
approved these changes
Nov 7, 2023
markphelps
reviewed
Nov 8, 2023
There was a problem hiding this comment.
Is it possible to add output to the build command that it expects a ref as an argument?
It doesn't seem clear to me from the defaults that cobra give us:
workspace/flipt - [gm/bundles-build] » ./bin/flipt bundle build
Error: accepts 1 arg(s), received 0
Usage:
flipt bundle build [flags]
Flags:
-h, --help help for build
workspace/flipt - [gm/bundles-build] » ./bin/flipt bundle build --help
Build a bundle
Usage:
flipt bundle build [flags]
Flags:
-h, --help help for build| @@ -87,6 +88,7 @@ func (c *exportCommand) run(cmd *cobra.Command, _ []string) error { | |||
| // default to stdout | |||
| out io.Writer = os.Stdout | |||
| logger = zap.Must(zap.NewDevelopment()) | |||
| enc = ext.EncodingYML | |||
There was a problem hiding this comment.
should we give the user the ability to set this format via a CLI flag now that we support JSON? could default to yaml still
There was a problem hiding this comment.
Ahh yeah I wondered about this. So it will support JSON if you specify a file with .json as the target.
However, for STDOUT, yeah we could have an actual flag. Same for import and STDIN.
Also wondering if we want to make it ignore our own |
Do you know which files you would expect to be included from the root of the Flipt repo itself? |
|
Yeah maybe an exclude directive for internal makes sense? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes FLI-653
Fixes FLI-657
This PR adds the following subcommands:
The
buildcommand builds a target directory containing flipt feature state into an OCI bundle.The target reference can be a local bundle name (e.g.
example:latest) or even a remote target (e.g.some.registry.io/example:latest).The
listcommand lists out existing local bundles.It also includes JSON support for
importandexport.