feat(oci): integrate new FS backend into Flipt #2359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Uffizzi Preview |
Codecov Report
@@ Coverage Diff @@
## gm/fs-oci #2359 +/- ##
=============================================
- Coverage 70.70% 70.58% -0.13%
=============================================
Files 81 81
Lines 7941 7956 +15
=============================================
+ Hits 5615 5616 +1
- Misses 1982 1996 +14
Partials 344 344
... and 1 file with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
GeorgeMac
force-pushed
the
gm/oci-integrate
branch
from
f3c4f52
to
208b4fc
Compare
markphelps
reviewed
Nov 9, 2023
| @@ -60,7 +62,15 @@ func (c *StorageConfig) setDefaults(v *viper.Viper) error { | |||
| v.SetDefault("storage.object.s3.poll_interval", "1m") | |||
| } | |||
| case string(OCIStorageType): | |||
There was a problem hiding this comment.
do we need to update the JSON and cue schemas as well for this?
There was a problem hiding this comment.
Ah yes, thank you!
markphelps
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes FLI-663
This the last PR to add the OCI backend to Flipt.
It installs the new OCI storage into the main Flipt process.
It also includes the wiring to add the OCI integration test suite to dagger and the associated GH workflow.