Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: UI changes for IS ONE OF #2388

Merged
merged 3 commits into from
Nov 13, 2023
Merged

feat: UI changes for IS ONE OF #2388

merged 3 commits into from
Nov 13, 2023

Conversation

phenax
Copy link
Contributor

@phenax phenax commented Nov 13, 2023

Changes (UI changes discussed in PR #2368)

  • Only shows 5 values by default. Clicking on the ellipsis, shows all the values
  • Adds placeholder for string and number values
  • Minor refactor of type state in form
Chip UI part-2023_11_13_18_09_50 part-2023_11_13_20_14_14
Placeholders part-2023_11_13_16_52_21 part-2023_11_13_20_34_46

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #2388 (e1630c3) into main (cd2f3b0) will not change coverage.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2388   +/-   ##
=======================================
  Coverage   70.51%   70.51%           
=======================================
  Files          81       81           
  Lines        7993     7993           
=======================================
  Hits         5636     5636           
  Misses       2012     2012           
  Partials      345      345           

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link
Collaborator

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you legend @phenax ! lgtm! thank you

@markphelps markphelps changed the title UI changes for IS ONE OF feat: UI changes for IS ONE OF Nov 13, 2023
@markphelps markphelps merged commit 551b7e7 into flipt-io:main Nov 13, 2023
28 of 29 checks passed
markphelps added a commit that referenced this pull request Nov 13, 2023
 into namespace-auth-token

* 'namespace-auth-token' of https://github.com/flipt-io/flipt:
  UI changes for `IS ONE OF` (#2388)
  chore(deps): bump golang.org/x/oauth2 from 0.13.0 to 0.14.0 (#2378)
markphelps added a commit that referenced this pull request Nov 13, 2023
@phenax phenax deleted the isoneof-ui branch November 15, 2023 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants