-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make oci manifest version configurable #2908
Conversation
If you accept this PR would be possible to make a minor release, please? 😄 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2908 +/- ##
==========================================
+ Coverage 70.78% 72.27% +1.49%
==========================================
Files 91 92 +1
Lines 8729 7146 -1583
==========================================
- Hits 6179 5165 -1014
+ Misses 2165 1597 -568
+ Partials 385 384 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for discovering and fixing this @thepabloaguilar !
Just a couple comments on here, otherwise, it looks great.
We can get this in a patch release for you 👍
300ed58
to
97744ac
Compare
Done @GeorgeMac! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me! thanks @thepabloaguilar !
Im guessing we should document this as well in our configuration docs?
Sure @markphelps! I'd document putting a note or smth saying the problem with AWS and it can happen for other providers. And I think we forgot to document the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solid!
@thepabloaguilar PR here flipt-io/docs#197 |
@thepabloaguilar Flipt |
* 'main' of https://github.com/flipt-io/flipt: feat: make oci manifest version configurable (#2908)
Hi! I'm opening this PR to fix that issue with AWS ECR, when using the OCI Manifest Version 1.1 I receive an error from AWS but when setting to version 1.0 everything works as expected!
So I make it configurable keeping the current using version as default! I searched a bit the code to see if flipt could have any impact on letting the users choose between versions and the answer is no, flipt won't use the newly added field (on 1.1 version)
subject
! If you want to compare: v1.0.2 abd v1.1.0Other people are having the same impact:
Fixes #2907