Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support BatchEvaluate #296

Merged
merged 8 commits into from
Jun 2, 2020
Merged

Support BatchEvaluate #296

merged 8 commits into from
Jun 2, 2020

Conversation

vic3lord
Copy link
Contributor

@vic3lord vic3lord commented Jun 1, 2020

This PR supports batch evaluation in a naive way without changing the db query but it helps moving the requests from client with multiple roundtrips to only a single client side request.

Fixes #61

Copy link
Collaborator

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great so far @vic3lord ! Thanks for the PR. Just a couple minor suggestions.

Also would you mind adding an Integration Test similar to the one here to test the funcionality of the batch-evaluate endpoint?

server/evaluator.go Outdated Show resolved Hide resolved
server/evaluator.go Outdated Show resolved Hide resolved
rpc/flipt.proto Outdated Show resolved Hide resolved
rpc/flipt.proto Outdated Show resolved Hide resolved
rpc/flipt.proto Outdated Show resolved Hide resolved
server/evaluator.go Outdated Show resolved Hide resolved
server/evaluator.go Outdated Show resolved Hide resolved
vic3lord and others added 7 commits June 2, 2020 08:45
Co-authored-by: Mark Phelps <markphelps@github.com>
Co-authored-by: Mark Phelps <markphelps@github.com>
Co-authored-by: Mark Phelps <markphelps@github.com>
Co-authored-by: Mark Phelps <markphelps@github.com>
@markphelps
Copy link
Collaborator

@all-contributors please add @vic3lord for code

@allcontributors
Copy link
Contributor

@markphelps

I've put up a pull request to add @vic3lord! 🎉

Copy link
Collaborator

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @vic3lord thank you for the contribution!

@markphelps markphelps merged commit 38b0be7 into flipt-io:master Jun 2, 2020
@vic3lord vic3lord deleted the BatchEvaluate branch June 2, 2020 19:17
@vic3lord
Copy link
Contributor Author

vic3lord commented Jun 2, 2020

@markphelps much appreciation for the swift response and willing to merge this 🙏

@markphelps
Copy link
Collaborator

@vic3lord I’ll create a new release tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Batch evaluation
2 participants