Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cache/redis): support ca certificate and insecure tls options #3107

Merged
merged 3 commits into from
May 24, 2024
Merged

feat(cache/redis): support ca certificate and insecure tls options #3107

merged 3 commits into from
May 24, 2024

Conversation

erka
Copy link
Collaborator

@erka erka commented May 23, 2024 •
edited
Loading

related #3105

@erka
feat(cache/redis): support tls ca certificate and insecure tls options
9da2fcf 
Signed-off-by: Roman Dmytrenko <rdmytrenko@gmail.com>
@codecov Codecov
Copy link

codecov bot commented May 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 72.35%. Comparing base (f997fb9) to head (46fd5e0).
Report is 359 commits behind head on main.

Files Patch % Lines
internal/cmd/grpc.go 0.00% 4 Missing ⚠️
internal/cache/redis/client.go 94.73% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3107      +/-   ##
==========================================
+ Coverage   70.78%   72.35%   +1.57%     
==========================================
  Files          91      102      +11     
  Lines        8729     7662    -1067     
==========================================
- Hits         6179     5544     -635     
+ Misses       2165     1708     -457     
- Partials      385      410      +25

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erka erka force-pushed the redis-ca-bundle branch 4 times, most recently from 8eee557 to 57f7bfd Compare May 23, 2024 16:35
@erka
added integration test for redis with tls
3f82830 
Signed-off-by: Roman Dmytrenko <rdmytrenko@gmail.com>
@erka erka marked this pull request as ready for review May 23, 2024 17:22
@erka erka requested a review from a team as a code owner May 23, 2024 17:22
GeorgeMac
GeorgeMac approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@GeorgeMac GeorgeMac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change is solid 💪 One vito-able thought around validating the mutual exclusiveness of CACertBytes and CACertPath. Otherwise. LGTM.

@erka
address PR feedback
46fd5e0 
Signed-off-by: Roman Dmytrenko <rdmytrenko@gmail.com>
markphelps
markphelps approved these changes May 24, 2024
View reviewed changes
Copy link
Collaborator

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! thank you @erka

@markphelps markphelps added needs docs Requires documentation updates automerge Used by Kodiak bot to automerge PRs labels May 24, 2024
@kodiakhq kodiakhq bot merged commit 02e2163 into flipt-io:main May 24, 2024
29 checks passed
@erka erka deleted the redis-ca-bundle branch May 24, 2024 12:56
@markphelps markphelps mentioned this pull request May 26, 2024
Closed
1 task
@YihongGao
Copy link

you guys are amazing 👍 👍 👍

@markphelps markphelps removed the needs docs Requires documentation updates label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeorgeMac GeorgeMac GeorgeMac approved these changes

@markphelps markphelps markphelps approved these changes

Assignees
No one assigned
Labels
automerge Used by Kodiak bot to automerge PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erka @YihongGao @markphelps @GeorgeMac