Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: write response for cloud login before server shutdown #3109

Merged
merged 1 commit into from
May 24, 2024

Conversation

markphelps
Copy link
Collaborator

Should fix: FLI-1037

Write the html response before sending the token down the channel which causes the server to shutdown

Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
@markphelps markphelps requested a review from a team as a code owner May 24, 2024 13:21
@markphelps markphelps requested a review from GeorgeMac May 24, 2024 13:21
@markphelps markphelps added the automerge Used by Kodiak bot to automerge PRs label May 24, 2024
Copy link
Contributor

@GeorgeMac GeorgeMac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice

@kodiakhq kodiakhq bot merged commit 4f30e3d into main May 24, 2024
30 checks passed
@kodiakhq kodiakhq bot deleted the cloud-login-race branch May 24, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Used by Kodiak bot to automerge PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants