Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent redis shutdown #3111

Merged
merged 1 commit into from
May 26, 2024
Merged

fix: prevent redis shutdown #3111

merged 1 commit into from
May 26, 2024

Conversation

vk-rv
Copy link
Contributor

@vk-rv vk-rv commented May 25, 2024

We found that redis shutdown is unexpected on grpc server exit while redeploying Flipt.
shutdown

@vk-rv vk-rv requested a review from a team as a code owner May 25, 2024 16:40
Signed-off-by: Oleg Vakarev <olegvakarev@Olegs-MacBook-Pro.local>
Copy link
Collaborator

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find. Thank you!

@markphelps
Copy link
Collaborator

@all-contributors please add @vk-rv for code

Copy link
Contributor

@markphelps

I've put up a pull request to add @vk-rv! 🎉

Copy link

codecov bot commented May 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 72.35%. Comparing base (f997fb9) to head (dbcfdb3).
Report is 363 commits behind head on main.

Files Patch % Lines
internal/cmd/grpc.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3111      +/-   ##
==========================================
+ Coverage   70.78%   72.35%   +1.57%     
==========================================
  Files          91      102      +11     
  Lines        8729     7662    -1067     
==========================================
- Hits         6179     5544     -635     
+ Misses       2165     1708     -457     
- Partials      385      410      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@markphelps markphelps added the automerge Used by Kodiak bot to automerge PRs label May 26, 2024
@kodiakhq kodiakhq bot merged commit c8b3b48 into flipt-io:main May 26, 2024
28 of 29 checks passed
@vk-rv vk-rv deleted the redis-shutdown branch May 27, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Used by Kodiak bot to automerge PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants