Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(audit): preserve audit log scheme #3151

Merged
merged 3 commits into from
Jun 7, 2024

Conversation

erka
Copy link
Collaborator

@erka erka commented Jun 6, 2024

related to #3101 #3113 (comment)

@erka erka requested a review from a team as a code owner June 6, 2024 14:25
@markphelps
Copy link
Collaborator

thanks @erka ! much better that its a non-breaking change now! i think we just need to fix the unit tests to account for this

@erka
Copy link
Collaborator Author

erka commented Jun 6, 2024

@markphelps I've already pushed the changed but it looks like Github has some issues. It shows the Processing updates next to the PR title for a while.

@markphelps
Copy link
Collaborator

@erka hmm maybe try pushing an empty commit? maybe GitHub was having some issues?

Signed-off-by: Roman Dmytrenko <rdmytrenko@gmail.com>
@erka erka force-pushed the restore-audit-log-scheme branch from 2560d6b to 492cd8b Compare June 7, 2024 06:39
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.

Project coverage is 71.65%. Comparing base (f997fb9) to head (985ba48).
Report is 385 commits behind head on main.

Current head 985ba48 differs from pull request most recent head 66aeda2

Please upload reports for the commit 66aeda2 to get more accurate results.

Files Patch % Lines
internal/server/audit/events.go 60.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3151      +/-   ##
==========================================
+ Coverage   70.78%   71.65%   +0.87%     
==========================================
  Files          91      106      +15     
  Lines        8729     7879     -850     
==========================================
- Hits         6179     5646     -533     
+ Misses       2165     1791     -374     
- Partials      385      442      +57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

erka added 2 commits June 7, 2024 12:55
Signed-off-by: Roman Dmytrenko <rdmytrenko@gmail.com>
Copy link
Collaborator

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@markphelps markphelps added the automerge Used by Kodiak bot to automerge PRs label Jun 7, 2024
@kodiakhq kodiakhq bot merged commit 9d4a6ef into flipt-io:main Jun 7, 2024
27 checks passed
@erka erka deleted the restore-audit-log-scheme branch June 7, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Used by Kodiak bot to automerge PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants