Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support postgresql url prefix #3354

Merged

Conversation

radekska
Copy link
Contributor

@radekska radekska commented Aug 5, 2024

this change resolves #3351 by registering postgresql URL alias.

@radekska radekska requested a review from a team as a code owner August 5, 2024 16:39
@radekska radekska force-pushed the feat/radekska/register.postgresql.alias branch from 7bdbbe9 to 8c5b244 Compare August 5, 2024 16:42
Signed-off-by: Radosław Skałbania <radoslaw@cast.ai>
@radekska radekska force-pushed the feat/radekska/register.postgresql.alias branch from 8c5b244 to 5fd75be Compare August 5, 2024 16:43
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.37%. Comparing base (97c7ed6) to head (5fd75be).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3354   +/-   ##
=======================================
  Coverage   64.36%   64.37%           
=======================================
  Files         172      172           
  Lines       13721    13722    +1     
=======================================
+ Hits         8832     8833    +1     
  Misses       4209     4209           
  Partials      680      680           
Flag Coverage Δ
unittests 64.37% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@markphelps
Copy link
Collaborator

@all-contributors please add @radekska for code

Copy link
Contributor

@markphelps

I've put up a pull request to add @radekska! 🎉

Copy link
Collaborator

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great to me! thanks for this @radekska

@radekska
Copy link
Contributor Author

radekska commented Aug 5, 2024

@markphelps glad I could help!

@markphelps markphelps added the automerge Used by Kodiak bot to automerge PRs label Aug 5, 2024
@kodiakhq kodiakhq bot merged commit 83964f1 into flipt-io:main Aug 5, 2024
33 checks passed
markphelps added a commit that referenced this pull request Aug 5, 2024
….com/flipt-io/flipt into support-import-export-namespace-data

* 'support-import-export-namespace-data' of https://github.com/flipt-io/flipt:
  chore(deps): bump golang.org/x/sync from 0.7.0 to 0.8.0 (#3347)
  chore(deps): bump go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp (#3349)
  chore(deps): bump github.com/aws/aws-sdk-go-v2/service/s3 (#3346)
  chore(deps): bump github.com/coreos/go-oidc/v3 from 3.10.0 to 3.11.0 (#3345)
  chore(deps): bump go.opentelemetry.io/otel/exporters/zipkin (#3348)
  docs: add radekska as a contributor for code (#3355)
  feat: support postgresql url prefix (#3354)
@radekska radekska deleted the feat/radekska/register.postgresql.alias branch August 6, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Used by Kodiak bot to automerge PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: regression in our support for postgresql:// scheme in DB URL
2 participants