fix: use different error messages for namespace scoped token errors #3358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgeMac
reviewed
Aug 7, 2024
| return ctx, errUnauthenticated | ||
| } | ||
| } | ||
| default: | ||
| // if the the token has a namespace but the request does not then we should reject the request | ||
| logger.Error("unauthenticated", | ||
| zap.String("reason", "namespace is not allowed")) | ||
| zap.String("reason", "namespace is requried when using namespace scoped token")) |
There was a problem hiding this comment.
Small typo:
Suggested change
| zap.String("reason", "namespace is requried when using namespace scoped token")) | |
| zap.String("reason", "namespace is required when using namespace scoped token")) |
There was a problem hiding this comment.
Thank you!
Fixed and rebased with signed-off commits.
Signed-off-by: Yohta Kimura <38206553+rajyan@users.noreply.github.com>
Signed-off-by: Yohta Kimura <38206553+rajyan@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3358 +/- ##
==========================================
+ Coverage 64.41% 64.44% +0.02%
==========================================
Files 172 172
Lines 13820 13820
==========================================
+ Hits 8902 8906 +4
+ Misses 4234 4232 -2
+ Partials 684 682 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@all-contributors please add @rajyan for code |
|
I've put up a pull request to add @rajyan! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had some difficulty debugging the namespace scoped token error, so improved the error message reason.