Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ui): make flags/segments views take up more screen space #3726

Merged
merged 5 commits into from
Dec 15, 2024

Conversation

markphelps
Copy link
Collaborator

@markphelps markphelps commented Dec 14, 2024

Redo the layout to make better use of space on the flags/segments views

Before

CleanShot 2024-12-14 at 16 53 12

After

CleanShot 2024-12-14 at 19 36 52@2x

CleanShot 2024-12-14 at 19 36 58@2x

Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
@markphelps markphelps requested a review from a team as a code owner December 14, 2024 21:55
Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
Copy link

codecov bot commented Dec 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.55%. Comparing base (cbad15e) to head (b2ead57).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3726   +/-   ##
=======================================
  Coverage   64.55%   64.55%           
=======================================
  Files         170      170           
  Lines       17163    17163           
=======================================
  Hits        11079    11079           
  Misses       5393     5393           
  Partials      691      691           
Flag Coverage Δ
unittests 64.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
@erka erka changed the title chore: make flags/segments views take up more screen space refactor(ui): make flags/segments views take up more screen space Dec 15, 2024
Copy link
Collaborator

@erka erka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@markphelps markphelps added the automerge Used by Kodiak bot to automerge PRs label Dec 15, 2024
@kodiakhq kodiakhq bot merged commit 2e3fd06 into main Dec 15, 2024
40 checks passed
@kodiakhq kodiakhq bot deleted the vertical-layout-flags-segments branch December 15, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Used by Kodiak bot to automerge PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants