Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attachment yaml #699

Merged
merged 13 commits into from
Feb 13, 2022
Merged

Attachment yaml #699

merged 13 commits into from
Feb 13, 2022

Conversation

markphelps
Copy link
Collaborator

Fixes: #697

  • Allow importing/exporting variant attachment JSON as YAML
  • Move import/export code to internal package and make more testable
  • Add import/export tests

* origin:
  Just use latest tag again
  try to fix dev image build
  Go 1.17 (#684)
  Bump @babel/core from 7.16.12 to 7.17.2 in /ui (#694)
  Bump @babel/plugin-transform-runtime from 7.16.10 to 7.17.0 in /ui (#691)
  Bump jest-environment-node from 27.4.6 to 27.5.1 in /ui (#695)
  Bump eslint-plugin-vue from 8.4.0 to 8.4.1 in /ui (#688)
  Bump @babel/runtime-corejs2 from 7.16.7 to 7.17.2 in /ui (#696)
  Add Paradigm on README (#692)
  Bump aquasecurity/trivy-action from 0.2.1 to 0.2.2 (#686)
@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2022

Codecov Report

Merging #699 (aa3fd93) into master (bdf53a4) will decrease coverage by 0.30%.
The diff coverage is 80.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #699      +/-   ##
==========================================
- Coverage   83.10%   82.80%   -0.31%     
==========================================
  Files          17       19       +2     
  Lines        1474     1692     +218     
==========================================
+ Hits         1225     1401     +176     
- Misses        217      245      +28     
- Partials       32       46      +14     
Impacted Files Coverage Δ
internal/ext/importer.go 77.50% <77.50%> (ø)
internal/ext/exporter.go 84.69% <84.69%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdf53a4...aa3fd93. Read the comment docs.

@markphelps markphelps enabled auto-merge (squash) February 13, 2022 18:28
@markphelps markphelps merged commit e91615c into master Feb 13, 2022
@markphelps markphelps deleted the attachment-yaml branch February 13, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import/Export variant attachment JSON as YAML
2 participants