Fix rules reordering from GRPC Gateway #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## releases/v1.8.2 #836 +/- ##
================================================
Coverage 81.79% 81.79%
================================================
Files 20 20
Lines 1802 1802
================================================
Hits 1474 1474
Misses 268 268
Partials 60 60 Continue to review full report at Codecov.
|
markphelps
added a commit
that referenced
this pull request
Apr 28, 2022
* Fix rules reordering from GRPC Gateway (#836) * Fix rules reordering from GRPC Gateway * Add IT * fix test * workflows * Rm space * Update changelog and helm chart * Serialize tasks * Clean
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #835
It seems a change in GRPC Gateway requires that the order of RPC methods matters.
The issue was that a
PUT /api/v1/flags/{flag_key}/rules/orderwas actually getting mapped to theUpdateRuleRPC method.Simply moving
OrderRulesbelowUpdateRulein the proto definition means that the last rule wins, so/api/v1/flags/{flag_key}/rules/ordershould map toOrderRulesnow