make message to sign content more obvious to prevent forgery #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goosewobbler
approved these changes
Jun 22, 2022
mholtzman
added a commit
that referenced
this pull request
Jun 24, 2022
* update test deps, scripts and config * separate electron-builder conf * remove space * update workflows * dont show zero balances on error (#897) * dont show zero balances on error * remove test code * address comments * better ux for verify address on device (#907) * better ux for verify address on device * left click only * clean up text logic * minor cleanup * make message to sign content more obvious to prevent forgery (#908) * make message to sign content more obvious to prevent forgery * Scroll notification * Cleanup Co-authored-by: Jordan Muir <jordan@frame.sh> * Trezor upgrades (#904) * update Trezor to use node packages * add temp scratch file * update temp file * update event flow * update event type * add comment, remove console log * add message and passphrase event handling * finish startup flow for trezor T * cleanup * add feedback on passphrase entry * update tests, UI * updates * remove comment * update flow for refresh and error handling * add ability to choose where to enter passphrase * fix tests * cleanup * revert verify button changes * revert changes * address comments * Style Trezor submit buttons * change any to unknown for errors Co-authored-by: Jordan Muir <jordan@frame.sh> * dont restart when frame is already running (#888) * use proxy connection for nebula (#836) * use proxy connection for nebula * fix connections * remove error catch * update startup sequence * use providers for nebula * fixes * remove console log * wait for nebula to be ready * update tests * update package lock Co-authored-by: goosewobbler <goosewobbler@pm.me> Co-authored-by: Jordan Muir <jordan@frame.sh>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.