sentry asar path stripping #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
goosewobbler
commented
Jul 2, 2022
•
goosewobbler
commented
- removing the path to the asar in sentry exceptions
- tests for the above
mholtzman
reviewed
Jul 5, 2022
added 2 commits
July 5, 2022 16:21
mholtzman
approved these changes
Jul 5, 2022
mholtzman
added a commit
that referenced
this pull request
Jul 12, 2022
* beta.21 * dont allow undefined 'to' field in transactions (#921) * get rid of inputref focus error * update package lock version * upgrade GridPlus SDK to v2.1.0 (#925) * return not connected if no connection is found for requested chain (#924) * sentry asar path stripping (#922) Co-authored-by: goosewobbler <goosewobbler@pm.me> * Worker process (#934) * add infrastructure for worker processes * add name * test * finish tests * IPFS getFile connection error fix (#932) Co-authored-by: goosewobbler <goosewobbler@pm.me> * limit sentry events (#930) * only allow one instance of Frame, focus instance when trying to run another instance * improve readability * add log for requested second instance * remove capital * sentry => errors, move exception handling * fix tests * limit sentry events * update for event rate limiting * tweak names * rename sentry to errors, move uncaughtExceptionHandler * Update test/main/sentry/index.test.js Co-authored-by: Matt Holtzman <matt.holtzman@gmail.com> * address review comments * add dialog import back * move captureException to correct place * Update index.js * Update index.js * Update index.js * Update index.test.js Co-authored-by: Matt Holtzman <matt.holtzman@gmail.com> Co-authored-by: goosewobbler <goosewobbler@pm.me> * only allow one instance of Frame, focus instance when trying to run a… (#927) * only allow one instance of Frame, focus instance when trying to run another instance * improve readability * add log for requested second instance * remove capital * app.exit * remove return Co-authored-by: goosewobbler <goosewobbler@pm.me> Co-authored-by: goosewobbler <432005+goosewobbler@users.noreply.github.com> * Update index.test.js * Update index.js * remove captureException * Use domains to handle worker updates (#929) * create worker process abstraction, use it for updates * update timeouts * finish worker abstractions * cleanup * revert timeout delay * use spawn instead of fork * dismiss window properly * address comments, make some methods private * add version display, move store access out of updater, add logging * update to not use electron in child process * add platform specific constructors * clean up whitespace, finish rebase * finish implementing electron app in auto updater * use domains * temp commit * get rid of dev stuff * cleanup * add error type * reset interval * PR fixes * Gridplus sdk 2.2.0 (#936) * Bumps gridplus-sdk to v2.2.0 * update package lock Co-authored-by: Doug Lance <doug.lance@gmail.com> * add path test, minor cleanup * added missing latestRelease * removed stray comma Co-authored-by: goosewobbler <goosewobbler@pm.me> Co-authored-by: goosewobbler <432005+goosewobbler@users.noreply.github.com> Co-authored-by: Doug Lance <doug.lance@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.