Remote control features #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is your car model ? On my side, I try to test with my Peugeot e208 but it is not eligible |
|
e-2008. Do you have the required services activated? (Used to be called "Remote Control" but I believe this is now part of "Connect Plus") |
|
Please also post the error here so it can be included in the FAQ if necessary. |
|
OK, I've not this option. I can't help you to tests these new features :'( |
|
thanks lgtm ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same additions as the previous pull request, but now without changing RemoteClient.py :)
I did not get around to testing the horn (did not want to wake up the neighbors), please someone else test it and advise if the count actually works. I have heard that it only horns three times regardless of set count but cannot verify this.
The lights do work, but they always flash for 10 seconds, regardless of set duration in PSACC. Maybe there is a way to remove the duration field in views.py (so no editing of RemoteClient.py)? I have tried it but ended up with no results.
Lock and unlocking doors also work. They work just like preconditioning the car. So 1 to lock and 0 to unlock.
Added the above to the readme and also cleaned that file up a bit.