-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added emscripten support for the Nim's gen script #1086
Conversation
Thanks for the PRs! I'm a bit busy atm with this Chrome WebGL2 regressions thingy (there goes the weekend lol), but I'll try to focus on those PRs some time next week. |
NOTE: the CI tests are expected to break because they don't have the changes in sokol-nim, don't worry about that. |
There is not rush at all, thanks @floooh! |
...checking now whether the CI runs through with the changes in sokol-nim merged, this will take a little bit... |
...ok actually got a real error in the CI pipeline now:
...I'll have a look locally... |
There's this difference between the generated version and sokol-nim:
I guess that |
Ok, I did this minor fix and then merged: b073c61 I didn't actually try to build for Emscripten, only for native macOS. I'll add a little blurb to the changelog next. Thanks for the PR! |
Related to floooh/sokol-nim#31