Skip to content

Commit

Permalink
Disable coverage
Browse files Browse the repository at this point in the history
  • Loading branch information
florenzen committed May 24, 2024
1 parent ebd531e commit fa03ede
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 8 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,10 @@ jobs:
env:
CI: true
CONFIGURATION: ${{ matrix.configuration }}
ENABLE_COVERAGE: true

- name: Build via Windows
if: runner.os == 'Windows'
run: ./build.cmd
env:
CI: true
CONFIGURATION: ${{ matrix.configuration }}
ENABLE_COVERAGE: true
1 change: 0 additions & 1 deletion .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,5 @@ jobs:
NUGET_TOKEN: ${{ secrets.NUGET_TOKEN }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
FAKE_DETAILED_ERRORS: true
ENABLE_COVERAGE: false # AltCover doesn't work with Release builds, reports lower coverage than actual
run: |
./build.sh Publish
4 changes: 0 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,6 @@ most of its build targets. The list of available targets can be obtained by
- `CONFIGURATION` will set the [configuration](https://docs.microsoft.com/en-us/dotnet/core/tools/dotnet-build?tabs=netcore2x#options) of the dotnet commands.
If not set, it will default to Release.
- `CONFIGURATION=Debug ./build.sh` will result in `-c` additions to commands such as in `dotnet build -c Debug`
- `ENABLE_COVERAGE` Will enable running code coverage metrics. AltCover can have
[severe performance degradation](https://github.com/SteveGilham/altcover/issues/57) so code coverage
evaluation are disabled by default to speed up the feedback loop.
- `ENABLE_COVERAGE=1 ./build.sh` will enable code coverage evaluation

## Debugging

Expand Down
4 changes: 3 additions & 1 deletion build/Build.fs
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,9 @@ let mutable changelogBackupFilename = ""

let publishUrl = "https://www.nuget.org"

let enableCodeCoverage = environVarAsBoolOrDefault "ENABLE_COVERAGE" false
// Coverage requirements do not really make sense here since most of the code
// runs during compilation of the tests.
let enableCodeCoverage = false

let githubToken = Environment.environVarOrNone "GITHUB_TOKEN"

Expand Down

0 comments on commit fa03ede

Please sign in to comment.