Sample Images for FlexBox5, SideDoorHousing,Tetris #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks pretty good already. If you want you can put the main images through https://tinypng.com/ as was done with most other pictures and regenerate the thumbnails after wards. But I can also just merge now and to that later myself. Should probably add that step to the CONSTRIBUTING file... |
|
Up to you but I can give it a go tomorrow. :) |
|
@florianfesti I have put the images through tinypng.com and added a new commit. Please let me know if my Pull Request is done wrong. I am still learning to use GIT/Github properly. One of the reasons I did not just upload the images to the ticket. |
|
Looks good! merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Samples Images for FlexBox5, SideDoorHousing, and Tetris
There is a second image for SideDoorHousing (I can add this to the generator as a second image in a separate commit)
included samples.sha256
Please let me know if I have done anything incorrectly. It was my first time committing to this project.