-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overdispersion #247
Overdispersion #247
Conversation
removed dependency on vioplot
@EttnerAndreas - can you have a look if you understand why this branch suddenly has a build error? This was created from the last update in master, but master checks out, and the branch previously also checked out! |
p.s., Andreas, can you do a review of this? This mostly concerns the code in the functions that are used by users, which are not so major, it's mainly a slight change in the standard overdispersion function, and the introduction of this parametric version of the overdispersion function. I would like to merge this all asap and get 0.3.4 on the way |
good job currently I am reviewing the new fucntions |
No, I didn't fix anything. Maybe this was just a travis problem, I didn't look at the error message, sometimes one just gets build errors because the tests run too long, and that can happen because the servers are overloaded, if you trigger a re-build, the error is gone! OK, thanks for the help function check. From my side, the branch could be merged! |
okay, think the text might disappeared. |
Hi Andreas, thanks, but if you do a review, please don't merge yet, I will always merge, just note what you think should be changed, or add improvements. Absolutely nothing unclear about the help ;) ? I must be on fire then! |
It is quite clear, nothing big but
-The type changed from Pearson to PearsonChisq, Is there a way to implement both? might be useful to have further help with the application. When to switch from type 'DHARMa' to 'PearsonChisq'
|
OK, thanks, I've made an issue for that! |
No description provided.