Changed default value for format in toDate scalar function (#809)

flow-php · Nov 20, 2023 · 6ead603 · 6ead603
1 parent 2c42e5f
commit 6ead603
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/examples/topics/aggregations/daily_revenue.php b/examples/topics/aggregations/daily_revenue.php
@@ -15,7 +15,7 @@
 $flow = (new Flow())
     ->read(Parquet::from(__FLOW_DATA__ . '/orders_flow.parquet'))
     ->select('created_at', 'total_price', 'discount')
-    ->withEntry('created_at', ref('created_at')->toDate(\DateTime::RFC3339)->dateFormat('Y/m'))
+    ->withEntry('created_at', ref('created_at')->toDate()->dateFormat('Y/m'))
     ->withEntry('revenue', ref('total_price')->minus(ref('discount')))
     ->select('created_at', 'revenue')
     ->groupBy('created_at')

diff --git a/...pter/etl-adapter-parquet/tests/Flow/ETL/Adapter/Parquet/Tests/Integration/ParquetTest.php b/...pter/etl-adapter-parquet/tests/Flow/ETL/Adapter/Parquet/Tests/Integration/ParquetTest.php
@@ -59,7 +59,7 @@ public function test_writing_with_partitioning() : void
                 $this->createRow(1, new \DateTimeImmutable('2020-01-02 00:02:00')),
                 $this->createRow(1, new \DateTimeImmutable('2020-01-03 00:01:00')),
             )))
-            ->withEntry('date', ref('datetime')->toDate(\DateTimeInterface::RFC3339)->dateFormat())
+            ->withEntry('date', ref('datetime')->toDate()->dateFormat())
             ->partitionBy(ref('date'))
             ->write(Parquet::to($path))
             ->run();

diff --git a/src/core/etl/src/Flow/ETL/Function/EntryScalarFunction.php b/src/core/etl/src/Flow/ETL/Function/EntryScalarFunction.php
@@ -345,7 +345,7 @@ public function strReplace(string|array $search, string|array $replace) : Scalar
      *
      * @return ScalarFunction
      */
-    public function toDate(string $format = 'Y-m-d', \DateTimeZone $timeZone = new \DateTimeZone('UTC')) : ScalarFunction|EntryReference
+    public function toDate(string $format = \DateTimeInterface::RFC3339, \DateTimeZone $timeZone = new \DateTimeZone('UTC')) : ScalarFunction|EntryReference
     {
         return new ScalarFunctions(new Function\ToDate($this, $format, $timeZone));
     }