Hide data in ArrayMemory by default (#952)

src/core/etl/src/Flow/ETL/Memory/ArrayMemory.php

@@ -9,20 +9,13 @@
 final class ArrayMemory implements \Countable, Memory
 {
     /**
-     * @var array<array<string, mixed>>
-     */
-    public array $data;
-
-    /**
-     * @param array<mixed> $memory
+     * @param array<array-key, array<string, mixed>> $memory
      *
      * @throws InvalidArgumentException
      */
-    public function __construct(array $memory = [])
+    public function __construct(private array $memory = [])
     {
         $this->assertMemoryStructure($memory);
-        /** @var array<array-key, array<string, mixed>> $memory */
-        $this->data = $memory;
     }
 
     /**
@@ -36,7 +29,7 @@ public function chunks(int $size) : array
 
         $chunks = [];
 
-        foreach (\array_chunk($this->data, $size) as $chunk) {
+        foreach (\array_chunk($this->memory, $size) as $chunk) {
             $chunks[] = new self($chunk);
         }
 
@@ -45,7 +38,7 @@ public function chunks(int $size) : array
 
     public function count() : int
     {
-        return \count($this->data);
+        return \count($this->memory);
     }
 
     /**
@@ -55,7 +48,7 @@ public function count() : int
      */
     public function dump() : array
     {
-        return $this->data;
+        return $this->memory;
     }
 
     /**
@@ -70,7 +63,7 @@ public function flatValues() : array
     {
         $data = [];
 
-        foreach ($this->data as $entry) {
+        foreach ($this->memory as $entry) {
             $data[] = \array_values($entry);
         }
 
@@ -86,7 +79,7 @@ public function map(callable $callback) : array
     {
         $data = [];
 
-        foreach ($this->data as $entry) {
+        foreach ($this->memory as $entry) {
             $data[] = $callback($entry);
         }
 
@@ -100,7 +93,7 @@ public function save(array $data) : void
     {
         $this->assertMemoryStructure($data);
 
-        $this->data = \array_merge($this->data, $data);
+        $this->memory = \array_merge($this->memory, $data);
     }
 
     /**

src/core/etl/tests/Flow/ETL/Tests/Integration/Function/AddDynamicEntriesTest.php

@@ -33,7 +33,7 @@ public function test_adding_new_entries() : void
                 ['id' => 1, 'updated_at' => new \DateTimeImmutable('2020-01-01T00:00:00+00:00')],
                 ['id' => 2, 'updated_at' => new \DateTimeImmutable('2020-01-01T00:00:00+00:00')],
             ],
-            $memory->data
+            $memory->dump()
         );
     }
 }

src/core/etl/tests/Flow/ETL/Tests/Integration/Function/AddJsonTest.php

@@ -30,7 +30,7 @@ public function test_add_json_into_existing_reference() : void
             [
                 ['id' => 1, 'array' => ['a' => 1, 'b' => 2, 'c' => 3, 'd' => 4]],
             ],
-            $memory->data
+            $memory->dump()
         );
     }
 
@@ -52,7 +52,7 @@ public function test_add_json_string_into_existing_reference() : void
             [
                 ['id' => 1, 'array' => ['a' => 1, 'b' => 2, 'c' => 3, 'd' => 4]],
             ],
-            $memory->data
+            $memory->dump()
         );
     }
 
@@ -74,7 +74,7 @@ public function test_adding_json_as_object_from_string_entry() : void
                     'json' => '{"id":1,"name":"test"}',
                 ],
             ],
-            $memory->data
+            $memory->dump()
         );
     }
 
@@ -95,7 +95,7 @@ public function test_adding_json_from_string_entry() : void
                     'json' => '[{"id":1},{"id":2}]',
                 ],
             ],
-            $memory->data
+            $memory->dump()
         );
     }
 }

src/core/etl/tests/Flow/ETL/Tests/Integration/Function/AllTest.php

@@ -48,7 +48,7 @@ public function test_all_cases_found() : void
                 ['id' => 3, 'result' => 'not found'],
                 ['id' => 4, 'result' => 'found'],
             ],
-            $memory->data
+            $memory->dump()
         );
     }
 }

src/core/etl/tests/Flow/ETL/Tests/Integration/Function/AnyTest.php

@@ -48,7 +48,7 @@ public function test_any_case_found() : void
                 ['id' => 3, 'result' => 'not found'],
                 ['id' => 4, 'result' => 'found'],
             ],
-            $memory->data
+            $memory->dump()
         );
     }
 }

src/core/etl/tests/Flow/ETL/Tests/Integration/Function/ArrayExistsTest.php

@@ -35,7 +35,7 @@ public function test_array_exists() : void
                 ['id' => 1, 'has_array' => true],
                 ['id' => 2, 'has_array' => false],
             ],
-            $memory->data
+            $memory->dump()
         );
     }
 }

src/core/etl/tests/Flow/ETL/Tests/Integration/Function/ArrayExpandTest.php

@@ -36,7 +36,7 @@ public function test_expand_both() : void
                 ['id' => 1, 'expanded' => ['b' => 2]],
                 ['id' => 1, 'expanded' => ['c' => 3]],
             ],
-            $memory->data
+            $memory->dump()
         );
     }
 
@@ -61,7 +61,7 @@ public function test_expand_keys() : void
                 ['id' => 1, 'expanded' => 'b'],
                 ['id' => 1, 'expanded' => 'c'],
             ],
-            $memory->data
+            $memory->dump()
         );
     }
 
@@ -86,7 +86,7 @@ public function test_expand_values() : void
                 ['id' => 1, 'expanded' => 2],
                 ['id' => 1, 'expanded' => 3],
             ],
-            $memory->data
+            $memory->dump()
         );
     }
 }

src/core/etl/tests/Flow/ETL/Tests/Integration/Function/ArrayGetCollectionTest.php

@@ -38,7 +38,7 @@ public function test_array_get_collection() : void
                 ['id' => 1, 'result' => [['a' => 1, 'c' => 3], ['a' => 1, 'c' => 3], ['a' => 1, 'c' => 3]]],
                 ['id' => 2, 'result' => null],
             ],
-            $memory->data
+            $memory->dump()
         );
     }
 }

src/core/etl/tests/Flow/ETL/Tests/Integration/Function/ArrayGetTest.php

@@ -34,7 +34,7 @@ public function test_array_get() : void
                 ['id' => 1, 'result' => 2],
                 ['id' => 2, 'result' => null],
             ],
-            $memory->data
+            $memory->dump()
         );
     }
 }

src/core/etl/tests/Flow/ETL/Tests/Integration/Function/ArrayKeyRenameTest.php

@@ -35,7 +35,7 @@ public function test_array_key_rename() : void
                 ['id' => 1, 'array' => ['b' => 2, 'c' => 3, 'd' => 1]],
                 ['id' => 2, 'array' => null],
             ],
-            $memory->data
+            $memory->dump()
         );
     }
 }

src/core/etl/tests/Flow/ETL/Tests/Integration/Function/ArrayKeysStyleConvertTest.php

@@ -32,7 +32,7 @@ public function test_array_keys_style_convert() : void
             [
                 ['id' => 1, 'array' => ['camel-cased' => 1, 'snake-cased' => 2, 'space-word' => 3]],
             ],
-            $memory->data
+            $memory->dump()
         );
     }
 }

src/core/etl/tests/Flow/ETL/Tests/Integration/Function/ArrayMergeCollectionTest.php

@@ -39,7 +39,7 @@ public function test_array_merge_collection() : void
                 ['id' => 1, 'result' => ['a' => 1, 'b' => 2, 'c' => 3]],
                 ['id' => 2, 'result' => null],
             ],
-            $memory->data
+            $memory->dump()
         );
     }
 }

src/core/etl/tests/Flow/ETL/Tests/Integration/Function/ArrayMergeTest.php

@@ -36,7 +36,7 @@ public function test_array_merge() : void
                 ['id' => 1, 'array' => ['a' => 1, 'b' => 2, 'c' => 3]],
                 ['id' => 2, 'array' => null],
             ],
-            $memory->data
+            $memory->dump()
         );
     }
 }

src/core/etl/tests/Flow/ETL/Tests/Integration/Function/ArrayReverseTest.php

@@ -34,7 +34,7 @@ public function test_array_reverse() : void
                 ['id' => 1, 'array' => ['c' => 3, 'b' => 2, 'a' => 1]],
                 ['id' => 2, 'array' => null],
             ],
-            $memory->data
+            $memory->dump()
         );
     }
 }

src/core/etl/tests/Flow/ETL/Tests/Integration/Function/ArraySortTest.php

@@ -36,7 +36,7 @@ public function test_array_sort() : void
                 ['id' => 1, 'array' => ['a' => 1, 'b' => 2, 'c' => 3]],
                 ['id' => 2, 'array' => null],
             ],
-            $memory->data
+            $memory->dump()
         );
     }
 }

src/core/etl/tests/Flow/ETL/Tests/Integration/Function/ArrayUnpackTest.php

@@ -35,7 +35,7 @@ public function test_array_unpack() : void
                 ['id' => 1, 'a' => 1, 'b' => 2, 'c' => 3],
                 ['id' => 2],
             ],
-            $memory->data
+            $memory->dump()
         );
     }
 }

src/core/etl/tests/Flow/ETL/Tests/Integration/Function/BetweenTest.php

@@ -37,7 +37,7 @@ public function test_between_comparisons() : void
                     'not_between' => false,
                 ],
             ],
-            $memory->data
+            $memory->dump()
         );
     }
 }

src/core/etl/tests/Flow/ETL/Tests/Integration/Function/BinaryComparisonsTest.php

@@ -109,7 +109,7 @@ public function test_all_comparisons() : void
                     'type' => false,
                 ],
             ],
-            $memory->data
+            $memory->dump()
         );
     }
 }

src/core/etl/tests/Flow/ETL/Tests/Integration/Function/CapitalizeTest.php

@@ -31,7 +31,7 @@ public function test_to_lower() : void
             [
                 ['key' => 'this is title', 'capitalized' => 'This Is Title'],
             ],
-            $memory->data
+            $memory->dump()
         );
     }
 }

src/core/etl/tests/Flow/ETL/Tests/Integration/Function/CastTest.php

@@ -27,7 +27,7 @@ public function test_cast() : void
             [
                 ['date' => '2023-01-01T00:00:00+00:00'],
             ],
-            $memory->data
+            $memory->dump()
         );
     }
 }

src/core/etl/tests/Flow/ETL/Tests/Integration/Function/CombineTest.php

@@ -36,7 +36,7 @@ public function test_combine() : void
                 ['id' => 1, 'array' => ['a' => 1, 'b' => 2, 'c' => 3]],
                 ['id' => 2, 'array' => null],
             ],
-            $memory->data
+            $memory->dump()
         );
     }
 }

src/core/etl/tests/Flow/ETL/Tests/Integration/Function/ConcatTest.php

@@ -36,7 +36,7 @@ public function test_concat_on_non_string_value() : void
                 ['id' => 1, 'concat' => null],
                 ['id' => 2, 'concat' => null],
             ],
-            $memory->data
+            $memory->dump()
         );
     }
 
@@ -61,7 +61,7 @@ public function test_concat_on_stringable_value() : void
                 ['id' => 1, 'concat' => '1-value'],
                 ['id' => 2, 'concat' => null],
             ],
-            $memory->data
+            $memory->dump()
         );
     }
 }

src/core/etl/tests/Flow/ETL/Tests/Integration/Function/ContainsTest.php

@@ -32,7 +32,7 @@ public function test_contains() : void
             [
                 ['key' => 'value', 'contains' => true],
             ],
-            $memory->data
+            $memory->dump()
         );
     }
 
@@ -54,7 +54,7 @@ public function test_contains_on_non_string_key() : void
             [
                 ['id' => 1, 'contains' => false],
             ],
-            $memory->data
+            $memory->dump()
         );
     }
 
@@ -76,7 +76,7 @@ public function test_contains_on_non_string_value() : void
             [
                 ['id' => '1', 'contains' => false],
             ],
-            $memory->data
+            $memory->dump()
         );
     }
 }

src/core/etl/tests/Flow/ETL/Tests/Integration/Function/CountTest.php

@@ -31,7 +31,7 @@ public function test_count_on_array() : void
             [
                 ['array' => [1, 2, 3], 'count' => 3],
             ],
-            $memory->data
+            $memory->dump()
         );
     }
 
@@ -53,7 +53,7 @@ public function test_count_on_non_countable() : void
             [
                 ['key' => 1, 'count' => null],
             ],
-            $memory->data
+            $memory->dump()
         );
     }
 
@@ -77,7 +77,7 @@ public function test_count_on_object() : void
             [
                 ['key' => $iterator, 'count' => 3],
             ],
-            $memory->data
+            $memory->dump()
         );
     }
 }