Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognize INT32 with deprecated ConvertedType as DateTimeImmutable object #1094

Conversation

norberttech
Copy link
Member

Change Log

Added

Fixed

  • Recognize INT32 with deprecated ConvertedType as DateTimeImmutable object

Changed

Removed

Deprecated

Security


Description

@norberttech norberttech force-pushed the feature/parquet-reading-deprecated-converted-types branch from 075c41a to b37ed79 Compare June 9, 2024 20:48
@github-actions github-actions bot added the core label Jun 9, 2024
Copy link
Contributor

github-actions bot commented Jun 9, 2024

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak         | mode             | rstdev          |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| AvroExtractorBench    | bench_extract_10k | 1    | 3   | 35.456mb +0.00%  | 833.087ms +0.75% | ±0.63% -79.77%  |
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 5.175mb +0.01%   | 337.768ms +0.40% | ±0.50% +177.07% |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 5.208mb +0.01%   | 1.079s +1.10%    | ±1.33% -4.19%   |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 135.878mb +0.00% | 748.822ms +0.44% | ±0.66% +3.33%   |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.965mb +0.01%   | 35.906ms -0.24%  | ±1.07% -32.29%  |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.971mb +0.01%   | 437.213ms +1.00% | ±0.43% -71.21%  |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev         |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 116.272mb +0.00% | 59.732ms -0.45% | ±0.59% -23.17% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev          |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| AvroLoaderBench    | bench_load_10k | 1    | 3   | 96.842mb +0.00%  | 449.247ms -1.50% | ±1.22% +397.48% |
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 55.254mb +0.00%  | 67.927ms -3.80%  | ±0.52% -80.10%  |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 107.628mb +0.00% | 51.606ms +0.07%  | ±0.56% +47.32%  |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 227.047mb +0.00% | 1.406s -0.44%    | ±0.39% -15.66%  |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 18.009mb +0.00%  | 38.551ms -2.08%  | ±0.76% +28.73%  |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev          |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 87.091mb +0.00%  | 3.767ms +9.90%   | ±0.67% +79.82%  |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 102.689mb +0.00% | 188.132ms +1.05% | ±1.12% +148.40% |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 85.409mb +0.00%  | 18.485ms -0.99%  | ±0.32% -76.47%  |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 88.331mb +0.00%  | 1.634ms -19.93%  | ±2.75% +970.78% |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 88.331mb +0.00%  | 1.662ms -17.21%  | ±1.32% -43.80%  |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 85.443mb +0.00%  | 2.753ms -11.99%  | ±1.13% -64.51%  |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 85.972mb +0.00%  | 15.949ms -2.34%  | ±0.86% -20.77%  |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 85.972mb +0.00%  | 16.119ms -2.68%  | ±0.74% -21.96%  |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 83.876mb +0.00%  | 1.600μs -5.55%   | ±0.00% -100.00% |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 83.876mb +0.00%  | 0.300μs -25.00%  | ±0.00% -100.00% |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 93.226mb +0.00%  | 12.118ms -2.29%  | ±0.81% -15.49%  |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 122.597mb +0.00% | 59.574ms -4.14%  | ±1.63% +22.48%  |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 86.492mb +0.00%  | 1.165ms -11.20%  | ±1.27% -37.61%  |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 89.839mb +0.00%  | 61.100ms -4.21%  | ±1.63% +120.63% |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 88.593mb +0.00%  | 4.008ms -3.28%   | ±2.35% +111.51% |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 84.020mb +0.00%  | 40.326ms +3.10%  | ±2.71% +40.60%  |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 84.020mb +0.00%  | 39.860ms +2.16%  | ±1.51% +183.22% |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 84.020mb +0.00%  | 39.370ms -0.29%  | ±0.50% -84.74%  |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 86.317mb +0.00%  | 7.418ms +0.35%   | ±1.19% +88.88%  |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 83.876mb +0.00%  | 28.566ms -1.17%  | ±1.88% +80.79%  |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 83.876mb +0.00%  | 13.690μs +2.93%  | ±3.35% +445.29% |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 83.876mb +0.00%  | 16.394μs +1.20%  | ±0.29% -80.95%  |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 102.690mb +0.00% | 190.744ms +0.10% | ±1.29% +28.63%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 116.821mb +0.00% | 494.895ms -1.09% | ±0.28% -76.56%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 60.299mb +0.00%  | 255.169ms +1.68% | ±2.20% +56.03%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 15.233mb +0.00%  | 54.878ms +2.63%  | ±1.16% +232.03% |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 60.000mb +0.00%  | 427.858ms -0.71% | ±0.63% +24.07%  |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 14.539mb +0.00%  | 91.427ms -1.75%  | ±2.77% +473.41% |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+

@norberttech norberttech merged commit 6db9c9e into flow-php:1.x Jun 9, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant