Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move implementation of entry structure creation into the NativeEntryFactory #619

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

stloyd
Copy link
Member

@stloyd stloyd commented Oct 20, 2023

Change Log

Added

Fixed

Changed

  • Move implementation of entry structure creation into the `NativeEntryFactory`

Removed

Deprecated

Security


Description

@norberttech
Copy link
Member

I would actually like to keep them as a simple functions if thats not creating any additional complications. This way they are more reusable and I already have some use cases in mind

@stloyd
Copy link
Member Author

stloyd commented Oct 20, 2023

Structure building right now is the only one that is done completely differently than others.

This also is a little confusing cause that function requires still having an entry factory.

@norberttech
Copy link
Member

This also is a little confusing cause that function requires still having an entry factory.

Valid point, it creates a weird dependency 👍

@norberttech norberttech merged commit 6308b88 into flow-php:1.x Oct 20, 2023
14 checks passed
@stloyd stloyd deleted the chore/array-stuct-factory branch October 20, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants