Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(etl-adapter-google-sheet): Fix scenario for empty google sheet. #641

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

scyzoryck
Copy link
Contributor

@scyzoryck scyzoryck commented Oct 24, 2023

Change Log

Added

Fixed

  • Fix extracting data from empty Google Sheet.

Changed

Removed

Deprecated

Security


Description

Fixes: #639

@scyzoryck scyzoryck changed the title fix(etl-adapter-google-sheet): Fix scenario for empty google sheet. Draft: fix(etl-adapter-google-sheet): Fix scenario for empty google sheet. Oct 24, 2023
@norberttech
Copy link
Member

thanks @scyzoryck could you please run locally composer build and try to fix the static analysis related issues so I can merge this?

@scyzoryck scyzoryck changed the title Draft: fix(etl-adapter-google-sheet): Fix scenario for empty google sheet. fix(etl-adapter-google-sheet): Fix scenario for empty google sheet. Oct 24, 2023
@scyzoryck
Copy link
Contributor Author

Unfortunately as long as googleapis/google-api-php-client-services#3679 is not solved we need to hide this error :(

@norberttech norberttech merged commit ca8dce6 into flow-php:1.x Oct 24, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue GoogleSheetExtractor with empty sheet.
2 participants