Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent fatal error when no values are set in ColumnChunkStatistics #658

Merged
merged 1 commit into from
Oct 29, 2023

Conversation

stloyd
Copy link
Member

@stloyd stloyd commented Oct 28, 2023

Change Log

Added

Fixed

  • Prevent fatal error when no values are set in `ColumnChunkStatistics`

Changed

Removed

Deprecated

Security


Description

Code borrowed from: #653

Error:

Fatal error: Uncaught DivisionByZeroError: Division by zero in /Users/stloyd/Documents/flow/src/lib/parquet/src/Flow/Parquet/ParquetFile/RowGroupBuilder/ColumnChunkStatistics.php:71
Stack trace:
#0 /Users/stloyd/Documents/flow/src/lib/parquet/src/Flow/Parquet/ParquetFile/RowGroupBuilder/PagesBuilder.php(25): Flow\Parquet\ParquetFile\RowGroupBuilder\ColumnChunkStatistics->cardinalityRation()
#1 /Users/stloyd/Documents/flow/src/lib/parquet/src/Flow/Parquet/ParquetFile/RowGroupBuilder/ColumnChunkBuilder.php(34): Flow\Parquet\ParquetFile\RowGroupBuilder\PagesBuilder->build(Object(Flow\Parquet\ParquetFile\Schema\FlatColumn), Array, Object(Flow\Parquet\ParquetFile\RowGroupBuilder\ColumnChunkStatistics))
#2 /Users/stloyd/Documents/flow/src/lib/parquet/src/Flow/Parquet/ParquetFile/RowGroupBuilder.php(63): Flow\Parquet\ParquetFile\RowGroupBuilder\ColumnChunkBuilder->flush(4)
#3 /Users/stloyd/Documents/flow/src/lib/parquet/src/Flow/Parquet/Writer.php(59): Flow\Parquet\ParquetFile\RowGroupBuilder->flush(4)
#4 /Users/stloyd/Documents/flow/var/profile.php(65): Flow\Parquet\Writer->write('/Users/stloyd/D...', Object(Flow\Parquet\ParquetFile\Schema), Array)
#5 {main}
  thrown in /Users/stloyd/Documents/flow/src/lib/parquet/src/Flow/Parquet/ParquetFile/RowGroupBuilder/ColumnChunkStatistics.php on line 71

@norberttech norberttech merged commit 2dbbfa2 into flow-php:1.x Oct 29, 2023
14 checks passed
@stloyd stloyd deleted the chore/parq-chunk-stat branch October 29, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants