Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a comment on each PR with phpbench results #660

Merged
merged 4 commits into from
Oct 29, 2023
Merged

Create a comment on each PR with phpbench results #660

merged 4 commits into from
Oct 29, 2023

Conversation

norberttech
Copy link
Member

@norberttech norberttech commented Oct 29, 2023 •
edited
Loading

Change Log

Added

  • Create a comment on each PR with phpbench results

Fixed

Changed

Removed

Deprecated

Security

Description

This should help us to early detect potential performance degradations in key elements of the ETL

@norberttech
Copy link
Member Author

since pull_request_target works in a context of the repository branch, not the fork I need to merge this first to verify how it works - I might need to revert that change

@norberttech norberttech merged commit 29872f1 into flow-php:1.x Oct 29, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci/cd size: S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@norberttech