Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework benchmarks to set up test data in constructors #662

Merged
merged 8 commits into from
Oct 29, 2023

Conversation

stloyd
Copy link
Member

@stloyd stloyd commented Oct 29, 2023

Change Log

Added

Fixed

Changed

  • Rework benchmarks to set up test data in constructors

Removed

Deprecated

Security


Description

To unify with other benchmarks, context is created once.

@stloyd stloyd changed the title Move context creation out of extractor benchmark methods Rework benchmarks to set up test data in constructors Oct 29, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2023

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+-----------+-----------+
| benchmark             | subject           | revs | its | mem_peak  | mode      |
+-----------------------+-------------------+------+-----+-----------+-----------+
| AvroExtractorBench    | bench_extract_10k | 5    | 3   | 44.123mb  | 418.555ms |
| CSVExtractorBench     | bench_extract_10k | 5    | 3   | 14.007mb  | 346.905ms |
| JsonExtractorBench    | bench_extract_10k | 5    | 3   | 18.669mb  | 716.145ms |
| ParquetExtractorBench | bench_extract_10k | 5    | 3   | 237.793mb | 979.979ms |
| TextExtractorBench    | bench_extract_10k | 5    | 3   | 7.277mb   | 14.090ms  |
| XmlExtractorBench     | bench_extract_10k | 5    | 3   | 7.624mb   | 605.596ms |
+-----------------------+-------------------+------+-----+-----------+-----------+
Transformers
+-----------------------------+--------------------------+------+-----+----------+----------+
| benchmark                   | subject                  | revs | its | mem_peak | mode     |
+-----------------------------+--------------------------+------+-----+----------+----------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 5    | 5   | 87.062mb | 59.864ms |
+-----------------------------+--------------------------+------+-----+----------+----------+
Loaders
+--------------------+----------------+------+-----+-----------+-----------+
| benchmark          | subject        | revs | its | mem_peak  | mode      |
+--------------------+----------------+------+-----+-----------+-----------+
| AvroLoaderBench    | bench_load_10k | 5    | 3   | 219.956mb | 684.346ms |
| CSVLoaderBench     | bench_load_10k | 5    | 3   | 47.140mb  | 68.747ms  |
| JsonLoaderBench    | bench_load_10k | 5    | 3   | 88.580mb  | 70.222ms  |
| ParquetLoaderBench | bench_load_10k | 5    | 3   | 281.201mb | 966.341ms |
| TextLoaderBench    | bench_load_10k | 5    | 3   | 16.567mb  | 36.214ms  |
+--------------------+----------------+------+-----+-----------+-----------+
Building Blocks
+-------------------------+----------------+------+-----+----------+-----------+
| benchmark               | subject        | revs | its | mem_peak | mode      |
+-------------------------+----------------+------+-----+----------+-----------+
| RowsBench               | bench_chunk_10 | 5    | 5   | 57.617mb | 3.544ms   |
| NativeEntryFactoryBench | bench_10k_rows | 5    | 5   | 83.908mb | 138.678ms |
| NativeEntryFactoryBench | bench_1k_rows  | 5    | 5   | 45.442mb | 13.897ms  |
| NativeEntryFactoryBench | bench_5k_rows  | 5    | 5   | 62.723mb | 69.671ms  |
+-------------------------+----------------+------+-----+----------+-----------+

@norberttech norberttech merged commit d4e865f into flow-php:1.x Oct 29, 2023
14 checks passed
@stloyd stloyd deleted the chore/extract-bench branch October 29, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants