Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for writing simple types nullable columns into parquet #668

Merged
merged 1 commit into from
Oct 29, 2023

Conversation

norberttech
Copy link
Member

Change Log

Added

  • Added support for writing simple types nullable columns into parquet

Fixed

Changed

Removed

Deprecated

Security


Description

Ref: #575

Writing nullable nested columns is still not working as expected, but it will be fixed in the next PR.

@github-actions
Copy link
Contributor

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+-----------+-----------+
| benchmark             | subject           | revs | its | mem_peak  | mode      |
+-----------------------+-------------------+------+-----+-----------+-----------+
| AvroExtractorBench    | bench_extract_10k | 5    | 3   | 44.122mb  | 488.008ms |
| CSVExtractorBench     | bench_extract_10k | 5    | 3   | 14.007mb  | 415.672ms |
| JsonExtractorBench    | bench_extract_10k | 5    | 3   | 18.669mb  | 830.575ms |
| ParquetExtractorBench | bench_extract_10k | 5    | 3   | 237.792mb | 1.110s    |
| TextExtractorBench    | bench_extract_10k | 5    | 3   | 7.277mb   | 15.757ms  |
| XmlExtractorBench     | bench_extract_10k | 5    | 3   | 7.624mb   | 686.782ms |
+-----------------------+-------------------+------+-----+-----------+-----------+
Transformers
+-----------------------------+--------------------------+------+-----+-----------------+------------------+
| benchmark                   | subject                  | revs | its | mem_peak        | mode             |
+-----------------------------+--------------------------+------+-----+-----------------+------------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 5    | 5   | 87.062mb -0.00% | 67.279ms -12.61% |
+-----------------------------+--------------------------+------+-----+-----------------+------------------+
Loaders
+--------------------+----------------+------+-----+-----------+-----------+
| benchmark          | subject        | revs | its | mem_peak  | mode      |
+--------------------+----------------+------+-----+-----------+-----------+
| AvroLoaderBench    | bench_load_10k | 5    | 3   | 219.956mb | 778.149ms |
| CSVLoaderBench     | bench_load_10k | 5    | 3   | 47.140mb  | 78.087ms  |
| JsonLoaderBench    | bench_load_10k | 5    | 3   | 88.580mb  | 78.208ms  |
| ParquetLoaderBench | bench_load_10k | 5    | 3   | 281.200mb | 1.121s    |
| TextLoaderBench    | bench_load_10k | 5    | 3   | 16.566mb  | 41.067ms  |
+--------------------+----------------+------+-----+-----------+-----------+
Building Blocks
+-------------------------+-----------------------+------+-----+----------+-----------+
| benchmark               | subject               | revs | its | mem_peak | mode      |
+-------------------------+-----------------------+------+-----+----------+-----------+
| RowsBench               | bench_chunk_10_on_10k | 5    | 5   | 57.617mb | 4.011ms   |
| RowsBench               | bench_drop_100_on_10k | 5    | 5   | 57.617mb | 5.976ms   |
| NativeEntryFactoryBench | bench_10k_rows        | 5    | 5   | 83.921mb | 160.241ms |
| NativeEntryFactoryBench | bench_1k_rows         | 5    | 5   | 45.430mb | 15.520ms  |
| NativeEntryFactoryBench | bench_5k_rows         | 5    | 5   | 62.716mb | 80.092ms  |
+-------------------------+-----------------------+------+-----+----------+-----------+

@norberttech norberttech merged commit a1d7f23 into flow-php:1.x Oct 29, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant