Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename docker-compose.yml to compose.yml to match specification #708

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

stloyd
Copy link
Member

@stloyd stloyd commented Nov 1, 2023

Change Log

Added

Fixed

Changed

  • Rename `docker-compose.yml` to `compose.yml` to match specification

Removed

Deprecated

Security


Description

This name matches the specification: https://www.compose-spec.io/
It works out-of-box with Docker Desktop.

Copy link
Contributor

github-actions bot commented Nov 1, 2023

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+-------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak         | mode              | rstdev          |
+-----------------------+-------------------+------+-----+------------------+-------------------+-----------------+
| AvroExtractorBench    | bench_extract_10k | 1    | 3   | 44.091mb +0.00%  | 429.099ms -16.78% | ±1.48% +264.65% |
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 13.976mb +0.00%  | 342.970ms -18.33% | ±0.23% +92.79%  |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 18.638mb +0.00%  | 696.082ms -17.61% | ±1.13% +415.98% |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 237.751mb +0.00% | 975.126ms -16.30% | ±0.19% -73.92%  |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 7.245mb +0.00%   | 18.501ms -27.03%  | ±1.48% -12.52%  |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 7.593mb +0.00%   | 615.257ms -17.37% | ±0.26% -90.70%  |
+-----------------------+-------------------+------+-----+------------------+-------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+-----------------+------------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak        | mode             | rstdev         |
+-----------------------------+--------------------------+------+-----+-----------------+------------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 87.032mb +0.00% | 67.355ms -16.81% | ±0.54% +23.64% |
+-----------------------------+--------------------------+------+-----+-----------------+------------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+-------------------+----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode              | rstdev         |
+--------------------+----------------+------+-----+------------------+-------------------+----------------+
| AvroLoaderBench    | bench_load_10k | 1    | 3   | 93.195mb +0.00%  | 693.652ms -18.11% | ±1.89% -28.25% |
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 47.109mb +0.00%  | 69.837ms -13.85%  | ±0.43% -2.17%  |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 88.543mb +0.00%  | 74.492ms -16.50%  | ±0.50% -32.63% |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 281.651mb +0.00% | 1.576s -17.42%    | ±0.44% -20.97% |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 16.530mb +0.00%  | 36.781ms -13.02%  | ±0.56% -64.58% |
+--------------------+----------------+------+-----+------------------+-------------------+----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+-----------------+-------------------+------------------+
| benchmark               | subject                    | revs | its | mem_peak        | mode              | rstdev           |
+-------------------------+----------------------------+------+-----+-----------------+-------------------+------------------+
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 60.656mb +0.00% | 4.150ms -29.43%   | ±3.29% +15.54%   |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 80.448mb +0.00% | 176.484ms -16.77% | ±0.75% +1399.62% |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 58.974mb +0.00% | 17.891ms -16.79%  | ±1.08% +133.86%  |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 59.794mb +0.00% | 2.997ms -18.98%   | ±1.48% -41.78%   |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 59.794mb +0.00% | 2.888ms -21.75%   | ±0.09% -96.67%   |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 59.008mb +0.00% | 3.880ms -23.85%   | ±1.56% -47.03%   |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 59.537mb +0.00% | 23.290ms -15.91%  | ±1.00% +1746.10% |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 59.536mb +0.00% | 23.107ms -20.46%  | ±1.50% -26.66%   |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 57.608mb +0.00% | 2.306μs -14.58%   | ±2.02% -33.19%   |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 57.608mb +0.00% | 0.400μs -20.00%   | ±0.00% +0.00%    |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 65.841mb +0.00% | 13.496ms -20.14%  | ±0.54% -72.29%   |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 91.361mb +0.00% | 60.575ms -16.48%  | ±0.37% +133.04%  |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 60.057mb +0.00% | 3.064ms -26.78%   | ±1.04% -27.10%   |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 62.327mb +0.00% | 46.698ms -17.90%  | ±0.84% +243.03%  |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 62.158mb +0.00% | 7.833ms -23.70%   | ±0.88% -75.40%   |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 57.608mb +0.00% | 50.113ms -19.03%  | ±0.10% -63.24%   |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 57.608mb +0.00% | 50.077ms -19.09%  | ±0.29% +5.71%    |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 57.608mb +0.00% | 50.485ms -19.43%  | ±0.41% -85.97%   |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 59.882mb +0.00% | 9.292ms -17.97%   | ±0.46% +282.34%  |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 57.607mb +0.00% | 37.429ms -18.36%  | ±0.13% -73.37%   |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 57.608mb +0.00% | 21.220μs -18.45%  | ±0.80% +22.71%   |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 57.608mb +0.00% | 26.200μs -18.23%  | ±0.00% -100.00%  |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 80.449mb +0.00% | 180.245ms -15.76% | ±0.46% +848.03%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 91.722mb +0.01% | 146.525ms -15.60% | ±0.24% +335.45%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 47.592mb -0.00% | 74.246ms -16.61%  | ±0.09% -75.49%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 12.389mb +0.00% | 17.658ms -16.46%  | ±0.53% -16.64%   |
+-------------------------+----------------------------+------+-----+-----------------+-------------------+------------------+

@norberttech norberttech merged commit 1e72305 into flow-php:1.x Nov 2, 2023
14 checks passed
@stloyd stloyd deleted the chore/docker-compose branch November 2, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants