Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new ListType logical type #749

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

stloyd
Copy link
Member

@stloyd stloyd commented Nov 6, 2023

Change Log

Added

  • Implement new `ListType` logical type

Fixed

Changed

Removed

Deprecated

Security


Description

Refs #746

Copy link
Contributor

github-actions bot commented Nov 6, 2023

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak         | mode             | rstdev          |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| AvroExtractorBench    | bench_extract_10k | 1    | 3   | 35.139mb +0.26%  | 366.892ms +1.05% | ±0.29% -43.65%  |
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.789mb +0.02%   | 269.175ms -0.32% | ±0.21% -2.41%   |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.937mb +0.23%   | 585.034ms +2.27% | ±1.28% +26.52%  |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 233.526mb +0.00% | 808.215ms +3.91% | ±1.11% +608.69% |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.783mb +0.02%   | 19.567ms +0.69%  | ±0.54% -65.19%  |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.783mb +0.02%   | 402.849ms +0.54% | ±0.13% -90.03%  |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+-----------------+-----------------+-----------------+
| benchmark                   | subject                  | revs | its | mem_peak        | mode            | rstdev          |
+-----------------------------+--------------------------+------+-----+-----------------+-----------------+-----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 87.049mb +0.00% | 50.302ms +3.79% | ±1.13% +147.62% |
+-----------------------------+--------------------------+------+-----+-----------------+-----------------+-----------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev         |
+--------------------+----------------+------+-----+------------------+------------------+----------------+
| AvroLoaderBench    | bench_load_10k | 1    | 3   | 93.290mb +1.21%  | 582.596ms +4.14% | ±1.34% -11.89% |
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 46.066mb +0.00%  | 70.220ms -2.00%  | ±0.83% -15.25% |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 88.568mb +1.28%  | 64.115ms +4.70%  | ±1.11% +19.36% |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 284.039mb +0.40% | 1.199s +2.40%    | ±0.85% +36.57% |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 16.560mb +0.01%  | 41.090ms -0.05%  | ±0.37% +46.17% |
+--------------------+----------------+------+-----+------------------+------------------+----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+-----------------+------------------+-----------------+
| benchmark               | subject                    | revs | its | mem_peak        | mode             | rstdev          |
+-------------------------+----------------------------+------+-----+-----------------+------------------+-----------------+
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 60.659mb +0.00% | 2.318ms +4.06%   | ±2.08% -37.95%  |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 80.451mb +0.00% | 155.037ms +5.09% | ±0.29% -22.56%  |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 58.977mb +0.00% | 15.346ms +3.65%  | ±0.01% -98.97%  |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 59.797mb +0.00% | 2.040ms +9.33%   | ±3.13% +6.35%   |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 59.797mb +0.00% | 2.048ms +14.13%  | ±1.56% +238.01% |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 59.011mb +0.00% | 2.865ms +7.80%   | ±1.15% -14.45%  |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 59.540mb +0.00% | 14.632ms +4.82%  | ±0.64% -39.21%  |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 59.539mb +0.00% | 14.641ms +4.82%  | ±1.67% +183.31% |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 57.611mb +0.00% | 1.806μs +0.68%   | ±2.57% -3.64%   |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 57.611mb +0.00% | 0.400μs 0.00%    | ±0.00% 0.00%    |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 65.844mb +0.00% | 10.798ms +5.96%  | ±1.44% +274.71% |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 91.364mb +0.00% | 49.391ms -0.46%  | ±0.42% -59.11%  |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 60.060mb +0.00% | 2.174ms +12.51%  | ±2.01% +80.25%  |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 62.330mb +0.00% | 34.168ms +2.87%  | ±0.34% -79.49%  |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 62.161mb +0.00% | 5.001ms +5.29%   | ±2.09% +14.65%  |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 57.611mb +0.00% | 38.226ms +3.49%  | ±1.07% +175.38% |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 57.611mb +0.00% | 38.731ms +4.90%  | ±0.33% +10.06%  |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 57.611mb +0.00% | 38.456ms +3.55%  | ±0.13% -77.17%  |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 59.885mb +0.00% | 7.378ms +1.44%   | ±0.74% -68.58%  |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 57.610mb +0.00% | 28.386ms -1.00%  | ±0.48% -41.00%  |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 57.611mb +0.00% | 13.021μs +1.87%  | ±0.96% -13.62%  |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 57.611mb +0.00% | 15.559μs +0.91%  | ±1.59% +74.51%  |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 80.452mb +0.00% | 158.229ms +2.00% | ±1.32% +81.26%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 91.719mb +1.24% | 122.025ms +4.98% | ±2.69% +103.86% |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 47.602mb +1.21% | 62.296ms +4.07%  | ±0.27% +7.31%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 12.392mb +0.94% | 14.294ms +3.08%  | ±1.58% -45.04%  |
+-------------------------+----------------------------+------+-----+-----------------+------------------+-----------------+

@stloyd stloyd marked this pull request as ready for review November 6, 2023 19:03
@norberttech norberttech merged commit 7558da4 into flow-php:1.x Nov 7, 2023
17 checks passed
@stloyd stloyd deleted the feature/list-type branch November 7, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants