Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed CSV loader working on remote streams #750

Conversation

norberttech
Copy link
Member

Change Log

Added

Fixed

  • CSV loader working on remote streams

Changed

Removed

  • BufferExtractor
  • Batch Size parameter from MemoryExtractor

Deprecated

Security


Description

Closes: #748

Copy link
Contributor

github-actions bot commented Nov 6, 2023

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+-------------------+------------------+
| benchmark             | subject           | revs | its | mem_peak         | mode              | rstdev           |
+-----------------------+-------------------+------+-----+------------------+-------------------+------------------+
| AvroExtractorBench    | bench_extract_10k | 1    | 3   | 35.138mb -0.02%  | 507.513ms +15.61% | ±1.15% +163.84%  |
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.790mb -0.00%   | 400.053ms +15.61% | ±1.16% +443.37%  |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.938mb -0.00%   | 776.713ms +11.20% | ±1.13% +430.63%  |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 233.527mb -0.00% | 1.211s +22.81%    | ±0.53% +251.89%  |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.783mb -0.00%   | 25.542ms +9.79%   | ±3.05% +176.02%  |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.784mb -0.00%   | 682.720ms +22.50% | ±2.11% +4799.10% |
+-----------------------+-------------------+------+-----+------------------+-------------------+------------------+
Transformers
+-----------------------------+--------------------------+------+-----+-----------------+------------------+-----------------+
| benchmark                   | subject                  | revs | its | mem_peak        | mode             | rstdev          |
+-----------------------------+--------------------------+------+-----+-----------------+------------------+-----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 87.050mb -0.00% | 77.674ms +16.19% | ±2.87% +171.84% |
+-----------------------------+--------------------------+------+-----+-----------------+------------------+-----------------+
Loaders
+--------------------+----------------+------+-----+------------------+-------------------+-----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode              | rstdev          |
+--------------------+----------------+------+-----+------------------+-------------------+-----------------+
| AvroLoaderBench    | bench_load_10k | 1    | 3   | 93.290mb -0.00%  | 838.322ms +16.69% | ±1.67% +0.80%   |
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 46.066mb -0.00%  | 79.977ms +14.86%  | ±1.16% +34.50%  |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 88.569mb -0.00%  | 86.276ms +13.70%  | ±1.35% +214.72% |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 284.039mb -0.00% | 1.829s +18.66%    | ±2.27% +701.86% |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 16.560mb -0.00%  | 44.048ms +21.20%  | ±1.05% -51.00%  |
+--------------------+----------------+------+-----+------------------+-------------------+-----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+-----------------+-------------------+------------------+
| benchmark               | subject                    | revs | its | mem_peak        | mode              | rstdev           |
+-------------------------+----------------------------+------+-----+-----------------+-------------------+------------------+
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 60.659mb -0.00% | 4.880ms +11.74%   | ±3.39% +26.64%   |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 80.452mb -0.00% | 209.392ms +17.88% | ±1.17% +81.47%   |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 58.977mb -0.00% | 21.403ms +18.44%  | ±1.78% +393.66%  |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 59.798mb -0.00% | 3.339ms +12.96%   | ±2.20% +103.13%  |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 59.798mb -0.00% | 3.236ms +9.03%    | ±1.41% +4.79%    |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 59.012mb -0.00% | 4.412ms +12.45%   | ±3.01% +317.07%  |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 59.540mb -0.00% | 25.385ms +9.44%   | ±2.96% +227.97%  |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 59.540mb -0.00% | 24.306ms +4.83%   | ±1.54% +77.43%   |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 57.611mb -0.00% | 2.494μs +13.05%   | ±1.91% -9.46%    |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 57.611mb -0.00% | 0.500μs +25.00%   | ±0.00% -100.00%  |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 65.845mb -0.00% | 16.825ms +24.53%  | ±0.93% +84.87%   |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 91.364mb -0.00% | 76.125ms +23.42%  | ±2.62% +277.05%  |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 60.061mb -0.00% | 3.560ms +13.10%   | ±3.07% +90.57%   |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 62.331mb -0.00% | 53.252ms +12.58%  | ±0.74% +38.65%   |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 62.162mb -0.00% | 8.472ms +9.12%    | ±1.61% +506.16%  |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 57.611mb -0.00% | 62.083ms +23.61%  | ±0.26% +26.20%   |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 57.611mb -0.00% | 60.952ms +21.46%  | ±1.02% +11.52%   |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 57.611mb -0.00% | 59.742ms +18.17%  | ±1.99% +334.89%  |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 59.886mb -0.00% | 11.899ms +27.49%  | ±3.32% +1540.51% |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 57.611mb -0.00% | 44.123ms +18.72%  | ±2.44% +4928.03% |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 57.611mb -0.00% | 26.341μs +25.93%  | ±0.95% -8.45%    |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 57.611mb -0.00% | 34.453μs +31.62%  | ±2.23% +208.52%  |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 80.452mb -0.00% | 212.338ms +18.15% | ±1.78% +52.68%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 91.731mb -0.00% | 180.463ms +22.30% | ±2.82% +931.35%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 47.608mb -0.02% | 88.964ms +18.84%  | ±2.22% +761.66%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 12.392mb -0.04% | 20.334ms +14.70%  | ±1.58% +1041.65% |
+-------------------------+----------------------------+------+-----+-----------------+-------------------+------------------+

@github-actions github-actions bot added the docs label Nov 6, 2023
@norberttech norberttech merged commit fcf09ad into flow-php:1.x Nov 6, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ETL Adapter CSV loader repeat headers
1 participant