Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed reading varInt #751

Conversation

norberttech
Copy link
Member

@norberttech norberttech commented Nov 6, 2023

Change Log

Added

Fixed

  • Fixed reading varInt

Changed

Removed

Deprecated

Security


Description

Closes: #722

Copy link
Contributor

github-actions bot commented Nov 6, 2023

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+-------------------+------------------+
| benchmark             | subject           | revs | its | mem_peak         | mode              | rstdev           |
+-----------------------+-------------------+------+-----+------------------+-------------------+------------------+
| AvroExtractorBench    | bench_extract_10k | 1    | 3   | 35.138mb +0.00%  | 356.305ms -18.84% | ±0.88% +102.29%  |
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.790mb +0.00%   | 270.061ms -21.96% | ±1.43% +570.93%  |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.938mb +0.00%   | 586.198ms -16.07% | ±2.00% +836.15%  |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 233.527mb +0.00% | 790.989ms -19.82% | ±0.60% +294.12%  |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.783mb +0.00%   | 20.012ms -13.98%  | ±1.73% +56.35%   |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.784mb +0.00%   | 399.695ms -28.28% | ±0.93% +2057.01% |
+-----------------------+-------------------+------+-----+------------------+-------------------+------------------+
Transformers
+-----------------------------+--------------------------+------+-----+-----------------+------------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak        | mode             | rstdev         |
+-----------------------------+--------------------------+------+-----+-----------------+------------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 87.050mb +0.00% | 47.917ms -28.32% | ±1.64% +55.15% |
+-----------------------------+--------------------------+------+-----+-----------------+------------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+-------------------+----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode              | rstdev         |
+--------------------+----------------+------+-----+------------------+-------------------+----------------+
| AvroLoaderBench    | bench_load_10k | 1    | 3   | 93.290mb +0.00%  | 577.234ms -19.65% | ±1.23% -25.97% |
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 46.066mb +0.00%  | 69.193ms -0.63%   | ±0.76% -11.83% |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 88.569mb +0.00%  | 60.059ms -20.85%  | ±0.27% -36.00% |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 284.039mb +0.00% | 1.172s -23.96%    | ±0.43% +52.52% |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 16.560mb +0.00%  | 40.729ms +12.07%  | ±0.52% -75.57% |
+--------------------+----------------+------+-----+------------------+-------------------+----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+-----------------+-------------------+------------------+
| benchmark               | subject                    | revs | its | mem_peak        | mode              | rstdev           |
+-------------------------+----------------------------+------+-----+-----------------+-------------------+------------------+
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 60.659mb +0.00% | 2.209ms -49.43%   | ±1.74% -34.99%   |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 80.452mb +0.00% | 152.399ms -14.20% | ±0.79% +23.22%   |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 58.977mb +0.00% | 15.206ms -15.85%  | ±0.29% -18.83%   |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 59.798mb +0.00% | 1.782ms -39.71%   | ±0.27% -75.26%   |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 59.798mb +0.00% | 1.743ms -41.27%   | ±2.43% +80.27%   |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 59.012mb +0.00% | 2.615ms -33.35%   | ±3.04% +321.40%  |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 59.540mb +0.00% | 13.996ms -39.66%  | ±1.01% +11.25%   |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 59.540mb +0.00% | 14.060ms -39.36%  | ±1.31% +50.55%   |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 57.611mb +0.00% | 1.806μs -18.13%   | ±2.57% +21.82%   |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 57.611mb +0.00% | 0.400μs 0.00%     | ±0.00% 0.00%     |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 65.845mb +0.00% | 10.128ms -25.04%  | ±0.75% +49.77%   |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 91.364mb +0.00% | 48.089ms -22.03%  | ±0.93% +34.19%   |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 60.061mb +0.00% | 1.905ms -39.46%   | ±1.22% -24.08%   |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 62.331mb +0.00% | 32.586ms -31.11%  | ±0.64% +20.10%   |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 62.162mb +0.00% | 4.679ms -39.73%   | ±1.18% +344.20%  |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 57.611mb +0.00% | 37.127ms -26.08%  | ±1.08% +430.62%  |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 57.611mb +0.00% | 36.927ms -26.42%  | ±1.33% +45.17%   |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 57.611mb +0.00% | 37.427ms -25.97%  | ±0.80% +74.88%   |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 59.886mb +0.00% | 7.254ms -22.28%   | ±2.30% +1033.79% |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 57.611mb +0.00% | 28.717ms -22.73%  | ±1.28% +2531.24% |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 57.611mb +0.00% | 12.820μs -38.71%  | ±1.33% +28.52%   |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 57.611mb +0.00% | 15.394μs -41.19%  | ±0.31% -57.59%   |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 80.452mb +0.00% | 155.820ms -13.29% | ±0.44% -62.04%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 91.731mb +0.00% | 122.668ms -16.87% | ±2.61% +855.28%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 47.608mb -0.03% | 61.367ms -18.02%  | ±2.89% +1020.87% |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 12.392mb +0.00% | 13.788ms -22.22%  | ±1.87% +1254.04% |
+-------------------------+----------------------------+------+-----+-----------------+-------------------+------------------+

@stloyd
Copy link
Member

stloyd commented Nov 6, 2023

Unfortunately there is still some warning: https://github.com/flow-php/flow/actions/runs/6774882629/job/18412933357?pr=751

1) /home/runner/work/flow/flow/src/lib/snappy/src/Flow/Snappy/SnappyCompressor.php:221
Undefined array key 2409

Triggered by:

* Flow\Parquet\Tests\Integration\IO\MapsWritingTest::test_writing_map_of_int_int
  /home/runner/work/flow/flow/src/lib/parquet/tests/Flow/Parquet/Tests/Integration/IO/MapsWritingTest.php:17

@stloyd stloyd merged commit d795d97 into flow-php:1.x Nov 6, 2023
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snappy & Parquet tests can throw warnings randomly
2 participants