Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Psalm configuration & adjust codebase #822

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

stloyd
Copy link
Member

@stloyd stloyd commented Nov 22, 2023

Change Log

Added

Fixed

Changed

  • Rework Psalm configuration & adjust codebase

Removed

Deprecated

Security


Description

Similar to #821

Copy link
Contributor

github-actions bot commented Nov 22, 2023

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak         | mode             | rstdev          |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| AvroExtractorBench    | bench_extract_10k | 1    | 3   | 34.763mb +0.00%  | 680.704ms +0.82% | ±1.92% +39.32%  |
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.628mb +0.01%   | 297.228ms -0.26% | ±0.58% -77.51%  |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.787mb +0.01%   | 908.665ms -0.77% | ±0.10% -71.12%  |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 239.497mb +0.00% | 1.091s -1.78%    | ±2.80% +220.98% |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.566mb +0.01%   | 24.763ms +2.88%  | ±2.55% +190.01% |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.567mb +0.01%   | 406.166ms -0.84% | ±0.22% -69.46%  |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev         |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 110.251mb +0.00% | 62.995ms -0.19% | ±0.23% -89.81% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev          |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| AvroLoaderBench    | bench_load_10k | 1    | 3   | 94.424mb +0.00%  | 449.627ms +0.56% | ±0.14% -64.49%  |
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 54.733mb +0.00%  | 71.149ms -0.44%  | ±0.67% -67.69%  |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 105.006mb +0.00% | 57.389ms +2.16%  | ±0.18% -36.36%  |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 320.484mb +0.00% | 1.503s +1.59%    | ±0.48% -37.70%  |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.608mb +0.00%  | 41.747ms +1.19%  | ±0.55% +114.65% |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev          |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 76.302mb +0.00%  | 3.040ms +2.40%   | ±1.04% -10.21%  |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 96.093mb +0.00%  | 177.791ms -2.76% | ±0.91% +51.74%  |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 74.618mb +0.00%  | 17.856ms +2.11%  | ±0.02% -94.48%  |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 77.542mb +0.00%  | 1.921ms +15.64%  | ±1.38% +29.01%  |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 77.542mb +0.00%  | 1.893ms +13.44%  | ±0.59% -79.67%  |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 74.654mb +0.00%  | 2.853ms +10.51%  | ±1.10% -55.36%  |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 75.183mb +0.00%  | 14.978ms +4.83%  | ±1.46% +36.23%  |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 75.183mb +0.00%  | 15.054ms +6.09%  | ±0.84% +67.12%  |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 73.086mb +0.00%  | 2.000μs +11.49%  | ±0.00% -100.00% |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 73.086mb +0.00%  | 0.400μs 0.00%    | ±0.00% 0.00%    |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 86.643mb +0.00%  | 14.035ms +10.50% | ±3.23% +448.59% |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 116.002mb +0.00% | 66.815ms +9.19%  | ±2.06% +28.11%  |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 75.703mb +0.00%  | 2.126ms +15.32%  | ±3.03% +160.36% |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 77.973mb +0.00%  | 34.405ms +4.83%  | ±0.61% +21.64%  |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 77.804mb +0.00%  | 4.344ms +11.20%  | ±2.30% +19.73%  |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 73.229mb +0.00%  | 38.532ms +1.62%  | ±0.83% +11.42%  |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 73.229mb +0.00%  | 39.184ms +2.14%  | ±0.91% +266.46% |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 73.229mb +0.00%  | 39.418ms +2.50%  | ±0.86% +51.20%  |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 75.528mb +0.00%  | 7.402ms -0.46%   | ±0.50% -61.18%  |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 73.086mb +0.00%  | 29.334ms +2.41%  | ±1.23% +472.96% |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 73.086mb +0.00%  | 13.734μs +2.65%  | ±1.50% +61.94%  |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 73.086mb +0.00%  | 16.558μs +4.10%  | ±1.76% +495.83% |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 96.094mb +0.00%  | 182.070ms -1.40% | ±1.06% -15.45%  |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 59.174mb +0.00%  | 335.383ms +3.41% | ±1.05% +82.33%  |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 14.097mb +0.00%  | 66.253ms +2.72%  | ±0.46% -20.61%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 115.845mb +0.00% | 374.180ms +0.79% | ±0.41% -53.73%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 59.563mb +0.00%  | 188.603ms +1.01% | ±0.99% -23.29%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.688mb +0.00%  | 40.306ms +1.35%  | ±0.39% -72.15%  |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+

UPGRADE.md Outdated Show resolved Hide resolved
coderabbitai[bot]

This comment was marked as outdated.

@flow-php flow-php deleted a comment from coderabbitai bot Nov 23, 2023
@norberttech norberttech merged commit a123021 into flow-php:1.x Nov 23, 2023
23 checks passed
@stloyd stloyd deleted the chore/psalm-config branch November 23, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants