Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Definition::isEqual() with random class order #838

Merged
merged 1 commit into from
Nov 25, 2023

Conversation

stloyd
Copy link
Member

@stloyd stloyd commented Nov 25, 2023

Change Log

Added

Fixed

  • Fix `Definition::isEqual()` with random class order

Changed

Removed

Deprecated

Security


Description

Copy link
Contributor

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak         | mode             | rstdev          |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| AvroExtractorBench    | bench_extract_10k | 1    | 3   | 34.762mb +0.00%  | 665.678ms -0.07% | ±1.68% -4.62%   |
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.627mb +0.01%   | 294.871ms -0.39% | ±0.15% +239.48% |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.786mb +0.00%   | 895.023ms -1.59% | ±2.66% +194.33% |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 239.496mb +0.00% | 1.082s -0.21%    | ±1.35% +335.86% |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.567mb +0.01%   | 23.993ms +2.12%  | ±1.35% +279.80% |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.568mb +0.01%   | 410.886ms -0.60% | ±1.85% +156.68% |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev         |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 110.251mb +0.00% | 65.014ms +2.72% | ±1.18% +97.80% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev          |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| AvroLoaderBench    | bench_load_10k | 1    | 3   | 94.423mb +0.00%  | 465.470ms +6.94% | ±2.39% +8.12%   |
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 54.733mb +0.00%  | 71.479ms -0.28%  | ±0.24% -73.38%  |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 105.005mb +0.00% | 56.593ms +5.30%  | ±1.05% +69.36%  |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 320.483mb +0.00% | 1.495s -1.72%    | ±1.20% -47.84%  |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.607mb +0.00%  | 40.858ms -2.94%  | ±1.48% +127.99% |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev           |
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 76.300mb +0.00%  | 2.778ms +6.46%   | ±3.19% +291.97%  |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 96.091mb +0.00%  | 182.593ms +2.80% | ±0.34% -42.49%   |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 74.617mb +0.00%  | 18.355ms +3.09%  | ±0.76% -12.28%   |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 77.540mb +0.00%  | 1.949ms +18.42%  | ±0.97% -43.79%   |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 77.540mb +0.00%  | 1.901ms +14.52%  | ±1.87% -24.98%   |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 74.652mb +0.00%  | 2.826ms +12.29%  | ±2.43% +100.65%  |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 75.181mb +0.00%  | 14.626ms -15.24% | ±0.09% -81.47%   |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 75.181mb +0.00%  | 15.037ms -12.46% | ±1.55% -20.12%   |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 73.084mb +0.00%  | 1.906μs -4.41%   | ±2.44% +1.72%    |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 73.084mb +0.00%  | 0.400μs 0.00%    | ±0.00% 0.00%     |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 86.641mb +0.00%  | 12.372ms -2.73%  | ±0.66% -69.83%   |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 116.000mb +0.00% | 63.922ms +2.73%  | ±2.43% +1182.90% |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 75.702mb +0.00%  | 1.833ms +6.40%   | ±2.30% -37.39%   |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 77.973mb +0.00%  | 34.462ms -9.64%  | ±1.06% +106.75%  |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 77.802mb +0.00%  | 3.936ms +2.01%   | ±1.33% +44.83%   |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 73.227mb +0.00%  | 39.995ms +1.46%  | ±1.58% +108.51%  |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 73.228mb +0.00%  | 39.249ms +0.87%  | ±0.09% -97.06%   |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 73.227mb +0.00%  | 40.071ms +0.75%  | ±1.81% +213.98%  |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 75.526mb +0.00%  | 7.385ms -0.17%   | ±0.28% -11.10%   |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 73.084mb +0.00%  | 29.142ms +0.44%  | ±0.52% -29.83%   |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 73.084mb +0.00%  | 13.280μs -0.20%  | ±1.27% +259.66%  |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 73.084mb +0.00%  | 15.706μs -0.09%  | ±0.30% -62.36%   |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 96.092mb +0.00%  | 185.916ms +2.89% | ±0.33% -60.87%   |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 59.172mb +0.00%  | 318.397ms -1.80% | ±0.39% -83.32%   |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 14.095mb +0.00%  | 62.174ms -1.87%  | ±0.53% -55.83%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 115.842mb +0.00% | 365.347ms -0.08% | ±1.79% +38.02%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 59.561mb +0.00%  | 183.484ms -0.12% | ±0.47% -69.48%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.685mb +0.00%  | 38.331ms -0.30%  | ±1.01% -35.67%   |
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+

@norberttech norberttech merged commit 905eeeb into flow-php:1.x Nov 25, 2023
17 checks passed
@stloyd stloyd deleted the bugfix/definition-equal branch November 25, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants