Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove class not available in the scope from README example #841

Merged
merged 1 commit into from
Nov 26, 2023

Conversation

rzarno
Copy link
Contributor

@rzarno rzarno commented Nov 26, 2023

Change Log

Added

Fixed

Changed

Removed

  • removed class reference not available in the scope from README example in CSV adapter

Deprecated

Security


Description

Copy link
Contributor

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak         | mode             | rstdev          |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| AvroExtractorBench    | bench_extract_10k | 1    | 3   | 34.763mb +0.00%  | 686.926ms +1.37% | ±1.26% -53.96%  |
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.628mb +0.00%   | 295.551ms -0.84% | ±0.39% +26.06%  |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.787mb +0.00%   | 920.135ms +0.12% | ±0.96% -67.62%  |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 239.497mb +0.00% | 1.086s -0.55%    | ±0.78% +384.20% |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.568mb +0.00%   | 23.507ms -0.92%  | ±1.00% +93.91%  |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.568mb +0.00%   | 404.790ms -0.06% | ±0.28% +4.01%   |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev         |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 110.251mb +0.00% | 62.865ms +1.45% | ±0.73% -34.65% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev          |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| AvroLoaderBench    | bench_load_10k | 1    | 3   | 94.424mb +0.00%  | 432.197ms -6.85% | ±1.16% -48.36%  |
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 54.733mb +0.00%  | 71.586ms -0.54%  | ±0.87% +188.04% |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 105.005mb +0.00% | 54.945ms -1.12%  | ±0.67% -25.74%  |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 320.484mb +0.00% | 1.482s +0.44%    | ±0.51% -5.06%   |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.608mb +0.00%  | 41.829ms -0.51%  | ±0.73% -23.09%  |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev          |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 76.301mb +0.00%  | 2.798ms -5.77%   | ±1.43% +71.10%  |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 96.091mb +0.00%  | 179.537ms -0.13% | ±0.37% -61.75%  |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 74.617mb +0.00%  | 17.840ms +2.15%  | ±0.30% -60.20%  |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 77.541mb +0.00%  | 1.730ms -1.10%   | ±3.89% +192.40% |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 77.541mb +0.00%  | 1.637ms -2.87%   | ±0.55% -71.32%  |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 74.653mb +0.00%  | 2.610ms +4.31%   | ±3.19% -2.39%   |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 75.182mb +0.00%  | 14.783ms +3.32%  | ±0.82% -7.66%   |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 75.182mb +0.00%  | 14.760ms +1.97%  | ±2.69% +45.70%  |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 73.085mb +0.00%  | 2.000μs +10.74%  | ±0.00% -100.00% |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 73.085mb +0.00%  | 0.400μs 0.00%    | ±0.00% 0.00%    |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 86.642mb +0.00%  | 13.358ms +2.63%  | ±1.12% -0.61%   |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 116.001mb +0.00% | 62.335ms -0.07%  | ±1.25% +193.00% |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 75.702mb +0.00%  | 1.903ms +2.93%   | ±1.04% -68.39%  |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 77.973mb +0.00%  | 35.220ms +2.25%  | ±2.44% +147.27% |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 77.803mb +0.00%  | 3.965ms -1.38%   | ±2.51% -35.47%  |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 73.228mb +0.00%  | 40.798ms +1.53%  | ±0.64% -40.77%  |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 73.228mb +0.00%  | 40.584ms -1.11%  | ±3.14% +58.85%  |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 73.228mb +0.00%  | 41.246ms +2.01%  | ±1.29% +1.77%   |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 75.527mb +0.00%  | 7.478ms +0.14%   | ±0.71% -4.92%   |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 73.085mb +0.00%  | 29.593ms +2.99%  | ±0.82% +58.31%  |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 73.085mb +0.00%  | 13.754μs +4.15%  | ±3.25% +812.56% |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 73.085mb +0.00%  | 15.788μs -0.08%  | ±1.65% +218.77% |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 96.093mb +0.00%  | 184.375ms +2.00% | ±1.17% +129.52% |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 59.173mb +0.00%  | 319.341ms -0.83% | ±0.36% +135.73% |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 14.096mb +0.00%  | 63.177ms +1.37%  | ±0.85% +25.86%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 115.843mb +0.00% | 363.527ms +0.57% | ±1.11% +125.38% |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 59.561mb +0.00%  | 180.563ms -2.06% | ±0.91% -44.72%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.686mb +0.00%  | 38.884ms +3.18%  | ±1.27% +87.92%  |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+

@norberttech norberttech merged commit 403671a into flow-php:1.x Nov 26, 2023
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants