Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize web composer.json with others #949

Closed
wants to merge 1 commit into from

Conversation

stloyd
Copy link
Member

@stloyd stloyd commented Feb 2, 2024

Change Log

Added

Fixed

Changed

  • Synchronize web `composer.json` with others

Removed

Deprecated

Security


Description

Copy link
Contributor

github-actions bot commented Feb 2, 2024

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak         | mode             | rstdev          |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| AvroExtractorBench    | bench_extract_10k | 1    | 3   | 35.264mb +0.00%  | 826.308ms +0.78% | ±1.03% -5.29%   |
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.984mb +0.01%   | 342.533ms +0.14% | ±0.36% +14.40%  |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 5.134mb +0.01%   | 1.038s -1.34%    | ±0.92% +153.37% |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 239.838mb +0.00% | 1.295s +3.46%    | ±0.69% +64.76%  |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.903mb +0.01%   | 35.122ms +0.72%  | ±0.96% +20.46%  |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.904mb +0.01%   | 430.470ms -1.37% | ±1.23% -3.00%   |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev         |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 110.604mb +0.00% | 65.095ms -0.26% | ±0.87% -34.03% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev         |
+--------------------+----------------+------+-----+------------------+------------------+----------------+
| AvroLoaderBench    | bench_load_10k | 1    | 3   | 95.645mb +0.00%  | 461.032ms -0.90% | ±0.42% +97.33% |
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 54.120mb +0.00%  | 72.447ms -0.60%  | ±0.11% -35.32% |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 106.549mb +0.00% | 53.035ms -1.45%  | ±0.89% +24.17% |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 321.760mb +0.00% | 1.489s -0.01%    | ±0.25% -61.23% |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.943mb +0.00%  | 40.913ms +0.27%  | ±0.20% -63.77% |
+--------------------+----------------+------+-----+------------------+------------------+----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev          |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 116.710mb +0.00% | 489.466ms -0.64% | ±0.14% -92.16%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 60.189mb +0.00%  | 247.198ms -2.52% | ±0.71% -70.38%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 15.122mb +0.00%  | 52.702ms -3.71%  | ±1.58% -27.43%  |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 59.961mb +0.00%  | 441.667ms +0.56% | ±0.50% -28.37%  |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 14.500mb +0.00%  | 87.872ms +1.83%  | ±1.59% +74.52%  |
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 76.679mb +0.00%  | 3.380ms -4.22%   | ±2.42% -16.92%  |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 96.405mb +0.00%  | 185.401ms +1.56% | ±1.38% +87.12%  |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 74.931mb +0.00%  | 18.910ms +2.77%  | ±0.65% -25.78%  |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 77.919mb +0.00%  | 1.684ms -6.62%   | ±1.04% +189.62% |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 77.919mb +0.00%  | 1.727ms -6.57%   | ±2.55% +6.34%   |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 75.031mb +0.00%  | 2.714ms -0.24%   | ±0.88% -68.09%  |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 75.560mb +0.00%  | 14.622ms +0.52%  | ±1.86% +128.98% |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 75.560mb +0.00%  | 14.344ms -3.58%  | ±1.09% +39.24%  |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 73.464mb +0.00%  | 1.894μs +11.01%  | ±2.53% -7.14%   |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 73.464mb +0.00%  | 0.400μs 0.00%    | ±0.00% 0.00%    |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 87.018mb +0.00%  | 13.109ms +1.06%  | ±1.61% +81.95%  |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 116.379mb +0.00% | 65.298ms +1.41%  | ±0.54% +132.45% |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 76.079mb +0.00%  | 1.305ms -1.71%   | ±3.41% +22.87%  |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 79.426mb +0.00%  | 61.670ms +4.13%  | ±1.59% +178.26% |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 78.181mb +0.00%  | 3.933ms +0.40%   | ±0.28% -50.61%  |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 73.542mb +0.00%  | 40.366ms -0.23%  | ±1.62% +414.13% |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 73.542mb +0.00%  | 39.856ms -1.32%  | ±2.58% +847.81% |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 73.542mb +0.00%  | 40.519ms -1.61%  | ±0.60% -49.67%  |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 75.905mb +0.00%  | 7.372ms +1.15%   | ±0.63% +90.22%  |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 73.464mb +0.00%  | 28.664ms -3.09%  | ±0.22% +42.97%  |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 73.464mb +0.00%  | 13.712μs +2.33%  | ±1.93% +217.51% |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 73.464mb +0.00%  | 16.099μs +2.58%  | ±1.52% +405.63% |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 96.407mb +0.00%  | 190.742ms +2.44% | ±0.43% +117.46% |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+

@@ -11,6 +11,7 @@
__DIR__ . '/src/core',
__DIR__ . '/src/adapter',
__DIR__ . '/src/lib',
__DIR__ . '/src/web',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm the way I was thinking about it was that we are going to build static content and only that static content would be published to standalone repo that would be gh static page.

I'm also not sure if we even want to keep the same composer.json for landing page, it's not that this landing page should use the same dependencies and the code, no?

@stloyd stloyd closed this Feb 2, 2024
@stloyd stloyd deleted the web-deps branch February 2, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants