[WIP][RFC] Move to native flow LSP #297
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flow natively supports the LSP now, so we can start to move this plugin over to the native Flow LSP.
I have 0 experience with LSP or VSCode extensions, so I'm looking for a lot of feedback here from people who know this technology better than I do.
I wanted to get the ball rolling on this quickly, since nuclide recently announced that it is retiring. If you feel like you can get this done quicker than I can, feel free to take over this PR.
Relevant configuration parsing in flow is here: https://github.com/facebook/flow/blob/master/hack/utils/lsp_fmt.ml#L799
I've tested by running the plugin via the instructions in CONTRIBUTING.md and writing flow with errors to see if the LSP catches them. It does. Here is my flow server log, which you can see is using the LSP:
log.txt