Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][fn] Go functions need to use static grpcPort in k8s runtime #2

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

flowchartsman
Copy link
Owner

Fixes apache#20403

Motivation

Allow Go pulsar functions to respond to the function worker for status requests.

Modifications

Make KubernetesRuntimeFactory assign static grpcPort instead of a random available port, so that the pod will respond correctly to status requests.

Verifying this change

  • Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage. I didn't see any tests for this, but if needed I can add them.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: TBD for full PR

@flowchartsman flowchartsman changed the title [Fix][pulsar-functions-go] Go functions need to use static grpcPort in k8s runtime [fix][pulsar-functions-go] Go functions need to use static grpcPort in k8s runtime May 25, 2023
@flowchartsman flowchartsman changed the title [fix][pulsar-functions-go] Go functions need to use static grpcPort in k8s runtime [fix][fn] Go functions need to use static grpcPort in k8s runtime May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Unable to communicate with Go Pulsar functions using the Kubernetes runtime.
1 participant