Add angular 13 support #86
Conversation
|
@AidasK @evilaliv3 @MartinNuc |
|
@MartinNuc can you review and merge this if all is ok? |
|
@MartinNuc gentle reminder |
|
@AidasK @MartinNuc gentle reminder 2 |
|
@itsaplev sorry for noticing this so late 🙈Going to merge it. Thank you so much for the contribution! 🚀 |
|
@AidasK @MartinNuc Thank you Martin! Could you please merge this pr and update NPM package? |
|
@MartinNuc Can you merge this and publish a new release? Thanks! |
|
@MartinNuc we are really looking forward to the new version |
|
Anyone wants maintainer permissions to release this? It looks like @MartinNuc could use some help |
|
|
Added, have fun @itsaplev :)) |
|
If you have any questions, don't hesitate to ask. I am not really familiar with angular, so that's why I am not taking this on myself. As for release, normal approach would be to release this as a new major version, such as v0.5.0 or even v1.0.0. Please don't release it on 0.4x as it might break things for others. |
|
@AidasK Ok! Thank you |
|
@AidasK I released 0.5.0, could you please update npm package? |
|
hmm, anyone knows how to publish this on https://www.npmjs.com/package/@flowjs/ngx-flow ? Ran npm publish, and it was published to https://www.npmjs.com/package/ngx-flow instead |
|
Anyway, did this, ran it again and it happened. fa6a5e9 Please double check if it's now working with angular 13 https://www.npmjs.com/package/@flowjs/ngx-flow?activeTab=versions |
|
Not sure why https://app.travis-ci.com/github/flowjs/ngx-flow/builds/249973163 fails @itsaplev can you confirm that |
|
@AidasK yes, there is missing test plugin in package.json I will fix it now update: But for CI used "npm run test:ci" and it is work fine. |
|
@AidasK about failed build, I've checked locally, it is really failed with this version of yarn 1.3.2 but it is ok with latest 1.12.18. We need to update yarn somehow at travis |
|
got it, fixed c673106 |
No description provided.