Recognize setwd as a side effect (#933)

* feat: support `setwd`

* lint-fix: handle linter errors

src/dataflow/environments/built-in.ts

@@ -174,7 +174,7 @@ registerSimpleFunctions(
 registerBuiltInFunctions(true,  ['apply', 'lapply', 'sapply', 'tapply', 'mapply'], defaultBuiltInProcessor,   { forceArgs: [false, true] }                                                 )
 registerBuiltInFunctions(true,  ['print'],                                         defaultBuiltInProcessor,   { returnsNthArgument: 0, forceArgs: 'all' as const }                         )
 registerBuiltInFunctions(true,  ['('],                                             defaultBuiltInProcessor,   { returnsNthArgument: 0 }                                                    )
-registerBuiltInFunctions(true,  ['load', 'load_all'],                              defaultBuiltInProcessor,   { hasUnknownSideEffects: true }                                              )
+registerBuiltInFunctions(true,  ['load', 'load_all', 'setwd'],                     defaultBuiltInProcessor,   { hasUnknownSideEffects: true, forceArgs: [true] }                           )
 registerBuiltInFunctions(false, ['cat'],                                           defaultBuiltInProcessor,   { forceArgs: 'all' as const }                                                ) /* returns null */
 registerBuiltInFunctions(false, ['switch'],                                        defaultBuiltInProcessor,   {}                                                                           ) /* returns null */
 registerBuiltInFunctions(true,  ['return'],                                        defaultBuiltInProcessor,   { returnsNthArgument: 0, cfg: ExitPointType.Return }                         )
@@ -201,5 +201,6 @@ registerBuiltInFunctions(true,  ['quote', 'substitute', 'bquote'],
 registerBuiltInFunctions(true,  ['for'],                                           processForLoop,            {}                                                                           )
 registerBuiltInFunctions(true,  ['repeat'],                                        processRepeatLoop,         {}                                                                           )
 registerBuiltInFunctions(true,  ['while'],                                         processWhileLoop,          {}                                                                           )
+
 /* they are all mapped to `<-` but we separate super assignments */
 registerReplacementFunctions({ makeMaybe: true },  ['<-', '<<-'], '[', '[[', '$', '@', 'names', 'dimnames', 'attributes', 'attr', 'class', 'levels', 'rownames', 'colnames')

src/r-bridge/data/data.ts

@@ -183,6 +183,12 @@ export const flowrCapabilities = {
 							supported:   'partially',
 							description: '_Handle cases like `print <- function(x) x`, `` `for` <- function(a,b,c) a``, ..._ Currently, we can not handle all of them there are no tests. Still wip as part of desugaring'
 						},
+						{
+							name:        'Functions with global side effects',
+							id:          'functions-with-global-side-effects',
+							supported:   'partially',
+							description: '_Support functions like `setwd` which have an impact on the subsequent program._'
+						},
 						{
 							name:         'Index Access',
 							id:           'index-access',

test/functionality/slicing/static-program-slices/calls-tests.ts

@@ -612,13 +612,17 @@ if(x == 3) {
 x`)
 		})
 		describe('Lapply Forcing the Map Function Body', () => {
-			assertSliced(label('Forcing Second Argument', []), shell,
-				'res <- lapply(1:3, function(x) x + 1)', ['1@res'],
-				'res <- lapply(1:3, function(x) x + 1)'
+			assertSliced(label('Forcing Second Argument', [
+				'name-normal', ...OperatorDatabase['<-'].capabilities, 'numbers', 'normal-definition', 'newlines', 'unnamed-arguments', 'call-normal', 'implicit-return'
+			]), shell,
+			'res <- lapply(1:3, function(x) x + 1)', ['1@res'],
+			'res <- lapply(1:3, function(x) x + 1)'
 			)
-			assertSliced(label('Forcing Including Reference', []), shell,
-				'foo <- bar()\nres <- lapply(1:3, function(x) foo * 2)', ['2@res'],
-				'foo <- bar()\nres <- lapply(1:3, function(x) foo * 2)'
+			assertSliced(label('Forcing Including Reference', [
+				'name-normal', ...OperatorDatabase['<-'].capabilities, 'numbers', 'normal-definition', 'newlines', 'unnamed-arguments', 'call-normal', 'implicit-return'
+			]), shell,
+			'foo <- bar()\nres <- lapply(1:3, function(x) foo * 2)', ['2@res'],
+			'foo <- bar()\nres <- lapply(1:3, function(x) foo * 2)'
 			)
 		})
 	})
@@ -653,4 +657,13 @@ x <- 2
 f()()
 x`)
 	})
+	describe('Calls with potential side effects', () => {
+		assertSliced(label('Changing the working directory', [
+			'functions-with-global-side-effects', 'name-normal', 'strings', 'call-normal', 'unnamed-arguments', 'newlines'
+		]), shell,
+		'setwd("f/")\nx', ['2@x'],
+		'setwd("f/")\nx'
+		)
+
+	})
 }))