Skip to content

Commit

Permalink
[release:patch] Fix: Incorrect Side-Effects for dev.off
Browse files Browse the repository at this point in the history
  • Loading branch information
@EagleoutIce
EagleoutIce committed Sep 13, 2024
1 parent 3eb1afc commit e97ab14
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/dataflow/environments/built-in.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ registerBuiltInFunctions(true, ['for'],
registerBuiltInFunctions(true, ['repeat'], processRepeatLoop, {} )
registerBuiltInFunctions(true, ['while'], processWhileLoop, {} )
registerBuiltInFunctions(false, ['options'], defaultBuiltInProcessor, { hasUnknownSideEffects: true, forceArgs: 'all' as const } )
registerBuiltInFunctions(false, ['on.exit', 'sys.on.exit', 'par', 'dev.off' ], defaultBuiltInProcessor, { hasUnknownSideEffects: true } )
registerBuiltInFunctions(false, ['on.exit', 'sys.on.exit', 'par' ], defaultBuiltInProcessor, { hasUnknownSideEffects: true } )
registerBuiltInFunctions(false, ['setnames', 'setNames', 'setkey', 'setkeyv', 'setindex', 'setindexv', 'setattr', 'sink' ], defaultBuiltInProcessor, { hasUnknownSideEffects: true } )

/* library and require is handled above */
Expand Down

2 comments on commit e97ab14

@EagleoutIce
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"artificial" Benchmark Suite

Benchmark suite Current: e97ab14 Previous: 44c526b Ratio
Retrieve AST from R code 237.97672204545452 ms (100.95361539859664) 239.42213677272727 ms (103.82313121172619) 0.99
Normalize R AST 21.414143136363638 ms (39.56891598363369) 20.457404363636364 ms (36.77082082099273) 1.05
Produce dataflow information 38.950916863636365 ms (85.69610850964092) 38.21900681818182 ms (81.34971002482807) 1.02
Total per-file 808.1631112727273 ms (1428.688046281115) 816.8130319090909 ms (1460.0152060402618) 0.99
Static slicing 2.228467730535544 ms (1.3740018187972964) 2.2454117276977246 ms (1.3672814394953574) 0.99
Reconstruct code 0.2245747020074741 ms (0.17586130505481137) 0.22823695438019298 ms (0.180587515271109) 0.98
Total per-slice 2.470040222573707 ms (1.4254046625840677) 2.4904620761066987 ms (1.4311425544325718) 0.99
failed to reconstruct/re-parse 0 # 0 # 1
times hit threshold 0 # 0 # 1
reduction (characters) 0.7869360165281424 # 0.7869360165281424 # 1
reduction (normalized tokens) 0.7639690077689504 # 0.7639690077689504 # 1
memory (df-graph) 147.42458274147728 KiB (358.6827375397903) 147.42458274147728 KiB (358.6827375397903) 1

This comment was automatically generated by workflow using github-action-benchmark.

@EagleoutIce
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"social-science" Benchmark Suite

Benchmark suite Current: e97ab14 Previous: 44c526b Ratio
Retrieve AST from R code 230.45514896 ms (41.928890449506795) 241.19898486000002 ms (44.93266335552592) 0.96
Normalize R AST 21.83893728 ms (16.824930859182228) 22.15083762 ms (17.078596378622905) 0.99
Produce dataflow information 71.77401414 ms (84.7721694767239) 74.87567007999999 ms (88.09994848451149) 0.96
Total per-file 10637.351617459999 ms (50105.335952081325) 11369.75587748 ms (54073.12372176306) 0.94
Static slicing 21.13796129326044 ms (74.99919647035496) 22.549699250990475 ms (80.89690479433877) 0.94
Reconstruct code 0.20996977181571297 ms (0.1323410404638652) 0.23785571716825718 ms (0.14842108337668944) 0.88
Total per-slice 21.355262023955028 ms (75.02211455722146) 22.79558156247473 ms (80.92056204842162) 0.94
failed to reconstruct/re-parse 0 # 0 # 1
times hit threshold 0 # 0 # 1
reduction (characters) 0.8719618340615195 # 0.8702425339407753 # 1.00
reduction (normalized tokens) 0.810633662275233 # 0.8080197262683358 # 1.00
memory (df-graph) 145.6434765625 KiB (153.49028997815503) 145.541875 KiB (153.47859961917467) 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.